* [PATCH] xfstests: define $seqres in btrfs/026-029
@ 2014-01-22 15:32 Koen De Wit
2014-01-22 16:55 ` Eric Sandeen
0 siblings, 1 reply; 2+ messages in thread
From: Koen De Wit @ 2014-01-22 15:32 UTC (permalink / raw)
To: xfs; +Cc: Koen De Wit
I forgot to define $seqres in btrfs/026-029. As a result, a file named
.full was created in the current working directory. Fix it.
---
tests/btrfs/026 | 1 +
tests/btrfs/027 | 1 +
tests/btrfs/028 | 1 +
tests/btrfs/029 | 1 +
4 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/tests/btrfs/026 b/tests/btrfs/026
index bf6f528..6c54590 100644
--- a/tests/btrfs/026
+++ b/tests/btrfs/026
@@ -26,6 +26,7 @@
#
seq=`basename $0`
+seqres=$RESULT_DIR/$seq
echo "QA output created by $seq"
here=`pwd`
diff --git a/tests/btrfs/027 b/tests/btrfs/027
index d76bb0f..b2dff1c 100644
--- a/tests/btrfs/027
+++ b/tests/btrfs/027
@@ -26,6 +26,7 @@
#-----------------------------------------------------------------------
seq=`basename $0`
+seqres=$RESULT_DIR/$seq
echo "QA output created by $seq"
here=`pwd`
diff --git a/tests/btrfs/028 b/tests/btrfs/028
index 06d2faf..f17f102 100644
--- a/tests/btrfs/028
+++ b/tests/btrfs/028
@@ -24,6 +24,7 @@
#-----------------------------------------------------------------------
seq=`basename $0`
+seqres=$RESULT_DIR/$seq
echo "QA output created by $seq"
here=`pwd`
diff --git a/tests/btrfs/029 b/tests/btrfs/029
index 1fd2a93..b93b6df 100644
--- a/tests/btrfs/029
+++ b/tests/btrfs/029
@@ -29,6 +29,7 @@
#-----------------------------------------------------------------------
seq=`basename $0`
+seqres=$RESULT_DIR/$seq
echo "QA output created by $seq"
here=`pwd`
--
1.7.1
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] xfstests: define $seqres in btrfs/026-029
2014-01-22 15:32 [PATCH] xfstests: define $seqres in btrfs/026-029 Koen De Wit
@ 2014-01-22 16:55 ` Eric Sandeen
0 siblings, 0 replies; 2+ messages in thread
From: Eric Sandeen @ 2014-01-22 16:55 UTC (permalink / raw)
To: Koen De Wit, xfs
On 1/22/14, 9:32 AM, Koen De Wit wrote:
> I forgot to define $seqres in btrfs/026-029. As a result, a file named
> .full was created in the current working directory. Fix it.
> ---
> tests/btrfs/026 | 1 +
> tests/btrfs/027 | 1 +
> tests/btrfs/028 | 1 +
> tests/btrfs/029 | 1 +
> 4 files changed, 4 insertions(+), 0 deletions(-)
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
presumably we can add your signed-off-by? ;)
I wonder if this can't be done in the common scripts:
# grep -h seqres= tests/*/??? | sort | uniq -c
349 seqres=$RESULT_DIR/$seq
rather than doing it in every single test ...
-Eric
>
> diff --git a/tests/btrfs/026 b/tests/btrfs/026
> index bf6f528..6c54590 100644
> --- a/tests/btrfs/026
> +++ b/tests/btrfs/026
> @@ -26,6 +26,7 @@
> #
>
> seq=`basename $0`
> +seqres=$RESULT_DIR/$seq
> echo "QA output created by $seq"
>
> here=`pwd`
> diff --git a/tests/btrfs/027 b/tests/btrfs/027
> index d76bb0f..b2dff1c 100644
> --- a/tests/btrfs/027
> +++ b/tests/btrfs/027
> @@ -26,6 +26,7 @@
> #-----------------------------------------------------------------------
>
> seq=`basename $0`
> +seqres=$RESULT_DIR/$seq
> echo "QA output created by $seq"
>
> here=`pwd`
> diff --git a/tests/btrfs/028 b/tests/btrfs/028
> index 06d2faf..f17f102 100644
> --- a/tests/btrfs/028
> +++ b/tests/btrfs/028
> @@ -24,6 +24,7 @@
> #-----------------------------------------------------------------------
>
> seq=`basename $0`
> +seqres=$RESULT_DIR/$seq
> echo "QA output created by $seq"
>
> here=`pwd`
> diff --git a/tests/btrfs/029 b/tests/btrfs/029
> index 1fd2a93..b93b6df 100644
> --- a/tests/btrfs/029
> +++ b/tests/btrfs/029
> @@ -29,6 +29,7 @@
> #-----------------------------------------------------------------------
>
> seq=`basename $0`
> +seqres=$RESULT_DIR/$seq
> echo "QA output created by $seq"
>
> here=`pwd`
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-01-22 16:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-22 15:32 [PATCH] xfstests: define $seqres in btrfs/026-029 Koen De Wit
2014-01-22 16:55 ` Eric Sandeen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).