From: Rich Johnston <rjohnston@sgi.com>
To: "Dave Chinner" <david@fromorbit.com>,
"Arkadiusz Miśkiewicz" <arekm@maven.pl>
Cc: xfs@oss.sgi.com
Subject: Re: xfsprogs 3.1.12 and 3.2.0 releases?
Date: Thu, 23 Jan 2014 16:37:21 -0600 [thread overview]
Message-ID: <52E199A1.4010902@sgi.com> (raw)
In-Reply-To: <20140122230356.GD27606@dastard>
On 01/22/2014 05:03 PM, Dave Chinner wrote:
> On Wed, Jan 22, 2014 at 03:48:52PM +0100, Arkadiusz Miśkiewicz wrote:
>> On Wednesday 22 of January 2014, Dave Chinner wrote:
>>> On Tue, Jan 21, 2014 at 09:17:38AM +0100, Arkadiusz Miśkiewicz wrote:
>>
>>>> By looking into git log these look like small fixes for 3.1.x. Could
>>>> someone else recheck?
>>>
>>> .....
>>>
>>>> 3a19fb7dce9d570e78deaf5c26c0ab8a4a5bef67 libxfs: stop caching inode
>>>> structures 61510437c627b529feb95ebffddd73df5ed5b104 repair: prefetching
>>>> is turned off unnecessarily 0cce4aa198f0470817bedb3781ea5b6955e43076
>>>> repair: Increase default repair parallelism on large filesystems
>>>
>>> I think these three are not a great idea for 3.1.x. They result in
>>> significant changes of behaviour that can result in increased memory
>>> consumption by default. I'd prefer that we don't make changes to the
>>> default behaviour in a bug-fix only point release.
>>
>> 3a19fb7dce9d570e78deaf5c26c0ab8a4a5bef67 libxfs: stop caching inode
>>
>> looks like wasting memory fix to me but ok.
>
> The last paragraph ofi the commit message points out the problems
> that can occur with memory consumption. For sparse inode
> populations, the buffer cache can consume much more memory than the
> inode cache did, and that can cause OOM problems with repair...
>
> As it is, it is a significant change of behaviour, so for a
> lightweight bug-fix only release I feel that it is out-of-scope...
>
> Cheers,
>
> Dave.
>
I'll get this put together by Monday unless someone else wants to do it.
--Rich
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-01-23 22:37 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-20 17:22 xfsprogs 3.1.12 and 3.2.0 releases? Arkadiusz Miśkiewicz
2014-01-20 22:30 ` Dave Chinner
2014-01-20 22:42 ` Arkadiusz Miśkiewicz
2014-01-20 23:02 ` Dave Chinner
2014-01-20 23:08 ` Christoph Hellwig
2014-01-20 23:11 ` Ben Myers
2014-01-21 8:17 ` Arkadiusz Miśkiewicz
2014-01-21 23:41 ` Dave Chinner
2014-01-22 14:38 ` Mark Tinguely
2014-01-22 14:54 ` Mark Tinguely
2014-01-22 14:48 ` Arkadiusz Miśkiewicz
2014-01-22 23:03 ` Dave Chinner
2014-01-23 22:37 ` Rich Johnston [this message]
2014-01-21 8:22 ` Christoph Hellwig
2014-01-27 18:46 ` [ANNOUNCE] xfsprogs for-3.1.12 branch has been updated to 40c65a7 Rich Johnston
2014-01-28 4:20 ` Dave Chinner
2014-01-28 15:36 ` Rich Johnston
2014-01-28 16:54 ` Ben Myers
2014-01-28 20:17 ` Dave Chinner
2014-01-28 4:42 ` Dave Chinner
2014-01-28 15:33 ` Rich Johnston
2014-01-28 20:15 ` Dave Chinner
2014-01-28 17:29 ` Arkadiusz Miśkiewicz
2014-01-30 19:20 ` Rich Johnston
2014-01-30 20:20 ` Eric Sandeen
2014-01-30 20:58 ` Rich Johnston
2014-02-19 19:18 ` Rich Johnston
2014-02-19 21:50 ` Dave Chinner
2014-03-14 15:28 ` Rich Johnston
2014-04-07 18:20 ` xfsprogs 3.1.12 and 3.2.0 releases? Rich Johnston
2014-04-07 23:30 ` Dave Chinner
2014-04-08 12:38 ` Rich Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52E199A1.4010902@sgi.com \
--to=rjohnston@sgi.com \
--cc=arekm@maven.pl \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).