From: Jeff Liu <jeff.liu@oracle.com>
To: Brian Foster <bfoster@redhat.com>, xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: remove spurious line continuation from _require_xfs_crc
Date: Wed, 29 Jan 2014 19:55:27 +0800 [thread overview]
Message-ID: <52E8EC2F.1080600@oracle.com> (raw)
In-Reply-To: <1390932092-44727-1-git-send-email-bfoster@redhat.com>
On 01/29 2014日 02:01 AM, Brian Foster wrote:
> This causes the mkfs to fail and leads to tests being skipped.
>
> Signed-off-by: Brian Foster <bfoster@redhat.com>
> ---
> common/rc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/common/rc b/common/rc
> index 49c86de..e91568b 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -1180,7 +1180,7 @@ _require_xfs_mkfs_crc()
> #
> _require_xfs_crc()
> {
> - _scratch_mkfs_xfs -m crc=1 >/dev/null 2>&1 \
> + _scratch_mkfs_xfs -m crc=1 >/dev/null 2>&1
> _scratch_mount >/dev/null 2>&1 \
> || _notrun "Kernel doesn't support crc feature"
> umount $SCRATCH_MNT
>
Looks good to me.
Reviewed-by: Jie Liu <jeff.liu@oracle.com>
Thanks,
-Jeff
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2014-01-29 11:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-28 18:01 [PATCH] xfstests: remove spurious line continuation from _require_xfs_crc Brian Foster
2014-01-29 11:55 ` Jeff Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52E8EC2F.1080600@oracle.com \
--to=jeff.liu@oracle.com \
--cc=bfoster@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).