* [PATCH] xfstests: remove spurious line continuation from _require_xfs_crc
@ 2014-01-28 18:01 Brian Foster
2014-01-29 11:55 ` Jeff Liu
0 siblings, 1 reply; 2+ messages in thread
From: Brian Foster @ 2014-01-28 18:01 UTC (permalink / raw)
To: xfs
This causes the mkfs to fail and leads to tests being skipped.
Signed-off-by: Brian Foster <bfoster@redhat.com>
---
common/rc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/rc b/common/rc
index 49c86de..e91568b 100644
--- a/common/rc
+++ b/common/rc
@@ -1180,7 +1180,7 @@ _require_xfs_mkfs_crc()
#
_require_xfs_crc()
{
- _scratch_mkfs_xfs -m crc=1 >/dev/null 2>&1 \
+ _scratch_mkfs_xfs -m crc=1 >/dev/null 2>&1
_scratch_mount >/dev/null 2>&1 \
|| _notrun "Kernel doesn't support crc feature"
umount $SCRATCH_MNT
--
1.8.1.4
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] xfstests: remove spurious line continuation from _require_xfs_crc
2014-01-28 18:01 [PATCH] xfstests: remove spurious line continuation from _require_xfs_crc Brian Foster
@ 2014-01-29 11:55 ` Jeff Liu
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Liu @ 2014-01-29 11:55 UTC (permalink / raw)
To: Brian Foster, xfs
On 01/29 2014日 02:01 AM, Brian Foster wrote:
> This causes the mkfs to fail and leads to tests being skipped.
>
> Signed-off-by: Brian Foster <bfoster@redhat.com>
> ---
> common/rc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/common/rc b/common/rc
> index 49c86de..e91568b 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -1180,7 +1180,7 @@ _require_xfs_mkfs_crc()
> #
> _require_xfs_crc()
> {
> - _scratch_mkfs_xfs -m crc=1 >/dev/null 2>&1 \
> + _scratch_mkfs_xfs -m crc=1 >/dev/null 2>&1
> _scratch_mount >/dev/null 2>&1 \
> || _notrun "Kernel doesn't support crc feature"
> umount $SCRATCH_MNT
>
Looks good to me.
Reviewed-by: Jie Liu <jeff.liu@oracle.com>
Thanks,
-Jeff
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-01-29 11:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-28 18:01 [PATCH] xfstests: remove spurious line continuation from _require_xfs_crc Brian Foster
2014-01-29 11:55 ` Jeff Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).