From: Jeff Liu <jeff.liu@oracle.com>
To: Brian Foster <bfoster@redhat.com>, xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: don't use TEST_DIR before initialized in generic/313
Date: Wed, 29 Jan 2014 19:58:21 +0800 [thread overview]
Message-ID: <52E8ECDD.8050303@oracle.com> (raw)
In-Reply-To: <1390950403-19755-1-git-send-email-bfoster@redhat.com>
On 01/29 2014 07:06 AM, Brian Foster wrote:
> The 'testfile' environment variable is initialized before the
> xfstests environment is included into generic/313. TEST_DIR is not
> defined at this point and causes the test to operate on the root.
> Move the testfile initialization down after the general environment
> is sourced.
>
> Signed-off-by: Brian Foster <bfoster@redhat.com>
> ---
> tests/generic/313 | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/generic/313 b/tests/generic/313
> index 1237ded..623c777 100755
> --- a/tests/generic/313
> +++ b/tests/generic/313
> @@ -29,7 +29,6 @@ seqres=$RESULT_DIR/$seq
> echo "QA output created by $seq"
>
> here=`pwd`
> -testfile=$TEST_DIR/testfile.$seq
> status=1 # failure is the default!
> trap "_cleanup; exit \$status" 0 1 2 3 15
>
> @@ -47,6 +46,8 @@ _cleanup()
> _supported_fs generic
> _supported_os IRIX Linux
>
> +testfile=$TEST_DIR/testfile.$seq
> +
> echo "Silence is golden"
>
> $here/src/t_truncate_cmtime $testfile 2>&1
Reviewed-by: Jie Liu <jeff.liu@oracle.com>
Thanks,
-Jeff
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2014-01-29 11:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-28 23:06 [PATCH] xfstests: don't use TEST_DIR before initialized in generic/313 Brian Foster
2014-01-29 11:58 ` Jeff Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52E8ECDD.8050303@oracle.com \
--to=jeff.liu@oracle.com \
--cc=bfoster@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).