From: Brian Foster <bfoster@redhat.com>
To: xfs@oss.sgi.com
Cc: hch@infradead.org
Subject: Re: [xfs] c91c46c12: xfstests generic/313 regression
Date: Wed, 29 Jan 2014 08:13:37 -0500 [thread overview]
Message-ID: <52E8FE81.7040402@redhat.com> (raw)
In-Reply-To: <20140111111045.GA29380@infradead.org>
On 01/11/2014 06:10 AM, Christoph Hellwig wrote:
> On Fri, Jan 10, 2014 at 10:01:00PM +0800, Jeff Liu wrote:
>> I also thought to fix this problem in this way, however I'm not sure
>> if those flags can be set back to iattr->ia_valid internally...
>>
>> Otherwise, this fix looks good to me.
>
> Nothing in the truncate or open code path (or non-size setattr for that
> matter) looks at ia_valid after calling the filesystem, and they really
> have no business to.
>
> In the meantime this has passed xfstests, so I'll send it along. Thanks
> for the first fix, btw!
>
ping... any plans to repost this with a proper commit log and whatnot?
Thanks.
Brian
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-01-29 13:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-10 12:27 [xfs] c91c46c12: xfstests generic/313 regression fengguang.wu
2014-01-10 13:22 ` Jeff Liu
2014-01-10 13:33 ` Christoph Hellwig
2014-01-10 14:01 ` Jeff Liu
2014-01-11 11:10 ` Christoph Hellwig
2014-01-29 13:13 ` Brian Foster [this message]
2014-01-29 16:35 ` Christoph Hellwig
2014-01-30 8:06 ` [PATCH] xfs: ensure correct timestamp updates from truncate Christoph Hellwig
2014-01-30 8:33 ` Jeff Liu
2014-01-30 13:57 ` Brian Foster
2014-01-30 15:47 ` Ben Myers
2014-02-03 10:23 ` Christoph Hellwig
2014-02-08 7:11 ` Christoph Hellwig
2014-02-16 14:45 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52E8FE81.7040402@redhat.com \
--to=bfoster@redhat.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).