From: "Michael L. Semon" <mlsemon35@gmail.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [NOISE] merge window blues, XFS broken
Date: Wed, 29 Jan 2014 17:31:00 -0500 [thread overview]
Message-ID: <52E98124.5060808@gmail.com> (raw)
In-Reply-To: <20140128095559.GJ2212@dastard>
On 01/28/2014 04:55 AM, Dave Chinner wrote:
> Ok, so xfs_inode_item_format+0x4a is inside the very first call to
> preapre the ilf structure. That tells us that the initial
> xfs_log_vec/xfs_log_iovec array are resulting in an unaligned
> buffer.
>
> Can you try the patch below, Michael?
>
> Cheers,
>
> Dave.
To the best of my knowledge, it works fine. It was subjected to some
of the xfstests xfs/* and generic/* series along with some of the
"log" group. In addition, it was run through fs_mark and a homebrew
benchmark idea of running a ( make clean; make ) loop for the kernel
while two fsx processes were running. This was for default (4k,
internal logdev) v5-superblock XFS filesystems. v4-superblock XFS
went through similar testing, to a lesser degree.
I did not know about a message like "log buf needs to be larger than
stripe size" on tests that require v2 logs. [xfs/087 might be one of
those tests.] This was also the case for the test-patch that padded
the structs directly, and this might be an old message.
At the very least, I'm keeping this patch. Your approach to the
solution looks cool. Basically, you're stating that you can have
either xfs_log_vec or xfs_log_iovec in there, and no matter what
their size, they get aligned in the log, correct?
Thanks!
Michael
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-01-29 22:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-26 19:35 [NOISE] merge window blues, XFS broken Michael L. Semon
2014-01-27 1:56 ` Dave Chinner
2014-01-27 7:41 ` Christoph Hellwig
2014-01-27 9:46 ` Michael L. Semon
2014-01-27 23:30 ` Dave Chinner
2014-01-28 8:22 ` Michael L. Semon
2014-01-28 9:55 ` Dave Chinner
2014-01-29 22:31 ` Michael L. Semon [this message]
2014-02-12 0:15 ` Michael L. Semon
2014-02-12 1:55 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52E98124.5060808@gmail.com \
--to=mlsemon35@gmail.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).