From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id A30E87F6B for ; Thu, 30 Jan 2014 02:33:45 -0600 (CST) Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by relay1.corp.sgi.com (Postfix) with ESMTP id 97B1A8F8066 for ; Thu, 30 Jan 2014 00:33:39 -0800 (PST) Received: from userp1040.oracle.com (userp1040.oracle.com [156.151.31.81]) by cuda.sgi.com with ESMTP id tLIIDI3ssfN0BWR0 (version=TLSv1 cipher=AES256-SHA bits=256 verify=NO) for ; Thu, 30 Jan 2014 00:33:38 -0800 (PST) Message-ID: <52EA0E41.7020102@oracle.com> Date: Thu, 30 Jan 2014 16:33:05 +0800 From: Jeff Liu MIME-Version: 1.0 Subject: Re: [PATCH] xfs: ensure correct timestamp updates from truncate References: <20140110122700.GA12624@localhost> <52CFF402.5080409@oracle.com> <20140110133306.GA22918@infradead.org> <52CFFD1C.7050005@oracle.com> <20140111111045.GA29380@infradead.org> <52E8FE81.7040402@redhat.com> <20140130080652.GA23758@infradead.org> In-Reply-To: <20140130080652.GA23758@infradead.org> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Christoph Hellwig Cc: xfs@oss.sgi.com On 01/30 2014 16:06 PM, Christoph Hellwig wrote: > The VFS doesn't set the proper ATTR_CTIME and ATTR_MTIME values for truncate, > so filesystems have to manually add them. The introduction of > xfs_setattr_time accidentally broke this special case an caused a > regression in generic/313. Fix this by removing the local mask variable > in xfs_setattr_size so that we only have a single place to keep the > attribute information. > > Signed-off-by: Christoph Hellwig > Reported-by: Fengguang Wu Reviewed-by: Jie Liu Thanks, -Jeff _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs