Re: [PATCH 4/6] xfs: add helper for verifying checksums on xfs_bufs

Dave Chinner
2014-02-10T03:33:29Z

On Sun, Feb 09, 2014 at 08:29:47PM -0600, Eric Sandeen wrote:
> Many/most callers of xfs_update_cksum() pass bp->b_addr and
> BBTOB(bp->b_length) as the first 2 args. Add a helper
> which can just accept the bp and the crc offset, and work
> it out on its own, for brevity.

The title of the patch is the same as the previous one - I think you
forgot to "update" it?

Other than that, same comments as for the previous patch.

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com