From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id A646A7F50 for ; Mon, 10 Feb 2014 19:25:49 -0600 (CST) Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by relay1.corp.sgi.com (Postfix) with ESMTP id 7C5688F8052 for ; Mon, 10 Feb 2014 17:25:49 -0800 (PST) Received: from song.cn.fujitsu.com (cn.fujitsu.com [222.73.24.84]) by cuda.sgi.com with ESMTP id FGkPNYGBkyQMlsRG for ; Mon, 10 Feb 2014 17:25:47 -0800 (PST) Message-ID: <52F97BC1.4090900@cn.fujitsu.com> Date: Tue, 11 Feb 2014 09:24:17 +0800 From: Wang Shilong MIME-Version: 1.0 Subject: Re: [PATCH] xfstests: btrfs/004: fix to make test really work References: <1392034256-2412-1-git-send-email-wangshilong1991@gmail.com> <20140210213944.GT13647@dastard> In-Reply-To: <20140210213944.GT13647@dastard> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: Wang Shilong , linux-btrfs@vger.kernel.org, xfs@oss.sgi.com On 02/11/2014 05:39 AM, Dave Chinner wrote: > On Mon, Feb 10, 2014 at 08:10:56PM +0800, Wang Shilong wrote: >> From: Wang Shilong >> >> So i was wandering why test 004 could pass my previous wrong >> kernel patch while it defenitely should not. >> >> By some debugging, i found here perl script is wrong, we did not >> filter out anything and this unit test did not work acutally.so >> it came out we will never fail this test. >> >> Signed-off-by: Wang Shilong >> --- >> tests/btrfs/004 | 7 +++---- >> 1 file changed, 3 insertions(+), 4 deletions(-) >> mode change 100755 => 100644 tests/btrfs/004 >> >> diff --git a/tests/btrfs/004 b/tests/btrfs/004 >> old mode 100755 >> new mode 100644 >> index 14da9f1..17a6e34 >> --- a/tests/btrfs/004 >> +++ b/tests/btrfs/004 >> @@ -57,10 +57,9 @@ _require_command "/usr/sbin/filefrag" >> >> rm -f $seqres.full >> >> -FILEFRAG_FILTER='if (/, blocksize (\d+)/) {$blocksize = $1; next} ($ext, '\ >> -'$logical, $physical, $expected, $length, $flags) = (/^\s*(\d+)\s+(\d+)'\ >> -'\s+(\d+)\s+(?:(\d+)\s+)?(\d+)\s+(.*)/) or next; $flags =~ '\ >> -'/(?:^|,)inline(?:,|$)/ and next; print $physical * $blocksize, "#", '\ >> +FILEFRAG_FILTER='if (/blocks of (\d+) bytes/) {$blocksize = $1; next} ($ext, '\ >> +'$logical, $physical, $length) = (/^\s*(\d+):\s+(\d+)..\s+\d+:'\ >> +'\s+(\d+)..\s+\d+:\s+(\d+):/) or next; print $physical * $blocksize, "#", '\ >> '$length * $blocksize, "#", $logical * $blocksize, " "' > Oh, boy, who allowed that mess to pass review? Please format this in > a readable manner while you are changing it. Yeah, i was thinking to make it more readable while i had sent this out.^_^ Thanks for your comments. Wang > > FILEFRAG_FILTER=' > if (/blocks of (\d+) bytes/) { \ > $blocksize = $1; \ > next; \ > } > ..... > > Cheers, > > Dave. _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs