From: Mark Tinguely <tinguely@sgi.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH v2] xfs_db: fix the setting of unaligned directory fields
Date: Tue, 11 Feb 2014 08:18:41 -0600 [thread overview]
Message-ID: <52FA3141.20901@sgi.com> (raw)
In-Reply-To: <20140211013145.GA13647@dastard>
On 02/10/14 19:31, Dave Chinner wrote:
> On Mon, Feb 10, 2014 at 05:09:12PM -0600, Mark Tinguely wrote:
<delete>
>> > + * Values larger than 64 bits are array of hex digits that
>> > + * already in the desired ordering (example UUID).
>> > */
>> > - *value = strtoll(arg, NULL, 0);
>> > + if (bit_length > 64)
>> > + return buf;
> I don't understand why you added this - how can we have input left
> that we need to parse after the above loop? @bytes will always be<=
> 0 at this point in time, which means we have no space in the bit
> field left to put values into....
The comment explains the return.
If the input bit_length is bigger than 64 bit then it is an array of hex
numbers (for example UUID can be entered this way).
buf is the beginning of the allocated array before rbuf pointer put
nibbles into it. So this returns the beginning of the hex bytes.
If this return is not taken then it is 64 bits or less and is some kind
of integer. The integer will get its fields fixed and converted to big
endian....
--Mark.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-02-11 14:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-10 23:09 [PATCH v2] xfs_db: fix the setting of unaligned directory fields Mark Tinguely
2014-02-11 1:31 ` Dave Chinner
2014-02-11 14:18 ` Mark Tinguely [this message]
2014-02-12 0:22 ` Dave Chinner
2014-02-12 21:37 ` Mark Tinguely
2014-02-13 20:25 ` [PATCH v3] " Mark Tinguely
2014-02-18 10:34 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52FA3141.20901@sgi.com \
--to=tinguely@sgi.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox