From: Koen De Wit <koen.de.wit@oracle.com>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-btrfs@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH v3] xfstests: Btrfs: add test for large metadata blocks
Date: Tue, 11 Feb 2014 20:01:08 +0100 [thread overview]
Message-ID: <52FA7374.2000209@oracle.com> (raw)
In-Reply-To: <20140210220400.GV13647@dastard>
[-- Attachment #1.1: Type: text/plain, Size: 812 bytes --]
On 02/10/2014 11:04 PM, Dave Chinner wrote:
> On Mon, Feb 10, 2014 at 10:39:22PM +0100, Koen De Wit wrote:
>> +
>> +_test_illegal_leafsize() {
>> + _scratch_mkfs -l $1 >>$seqres.full 2>&1
>> + [ $? -ne 0 ] || _fail "'$1' is an illegal value for the" \
>> + "leafsize option, mkfs should have failed."
>> +}
> You just re-implemented run_check....
I believe I didn't :
run_check()
{
echo "# $@" >> $seqres.full 2>&1
"$@" >> $seqres.full 2>&1 || _fail "failed: '$@'"
}
run_check() takes an arbitrary command and executes it, _test_illegal_leafsize() takes a leafsize as parameter and tries mkfs.btrfs with that leafsize. run_check() makes the test fail if the return code is not zero, _test_illegal_leafsize() does the opposite.
Thanks,
Koen.
[-- Attachment #1.2: Type: text/html, Size: 1421 bytes --]
[-- Attachment #2: Type: text/plain, Size: 121 bytes --]
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-02-11 19:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-10 21:39 [PATCH v3] xfstests: Btrfs: add test for large metadata blocks Koen De Wit
2014-02-10 22:04 ` Dave Chinner
2014-02-11 19:01 ` Koen De Wit [this message]
2014-02-17 1:57 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52FA7374.2000209@oracle.com \
--to=koen.de.wit@oracle.com \
--cc=david@fromorbit.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox