From: Mark Tinguely <tinguely@sgi.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH v2] xfs_db: fix the setting of unaligned directory fields
Date: Wed, 12 Feb 2014 15:37:13 -0600 [thread overview]
Message-ID: <52FBE989.1000304@sgi.com> (raw)
In-Reply-To: <20140212002222.GO13647@dastard>
On 02/11/14 18:22, Dave Chinner wrote:
> On Tue, Feb 11, 2014 at 08:18:41AM -0600, Mark Tinguely wrote:
>> On 02/10/14 19:31, Dave Chinner wrote:
...
> Hence I'd suggest that "if (bit_field & NBBY) return NULL;" is
> appropriate for hex block format input, and the input should never
> be treated as a host-endian integer...
>
> Cheers,
>
> Dave.
I don't like having the hex block format as an integer input. My change
would change the result if used as an integer, I just trying to keep
compatibility with the previous code.
I will gladly leave the hex block input alone and remove the test that
uses it as an integer.
--Mark.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-02-12 21:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-10 23:09 [PATCH v2] xfs_db: fix the setting of unaligned directory fields Mark Tinguely
2014-02-11 1:31 ` Dave Chinner
2014-02-11 14:18 ` Mark Tinguely
2014-02-12 0:22 ` Dave Chinner
2014-02-12 21:37 ` Mark Tinguely [this message]
2014-02-13 20:25 ` [PATCH v3] " Mark Tinguely
2014-02-18 10:34 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52FBE989.1000304@sgi.com \
--to=tinguely@sgi.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox