From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id 2EA217F55 for ; Thu, 13 Feb 2014 13:30:02 -0600 (CST) Message-ID: <52FD1D38.1010006@sgi.com> Date: Thu, 13 Feb 2014 13:30:00 -0600 From: Mark Tinguely MIME-Version: 1.0 Subject: Re: [PATCH 1/5] metadump: sanitise write_buf/index return values References: <1390472635-17225-1-git-send-email-david@fromorbit.com> <1390472635-17225-2-git-send-email-david@fromorbit.com> In-Reply-To: <1390472635-17225-2-git-send-email-david@fromorbit.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: xfs@oss.sgi.com On 01/23/14 04:23, Dave Chinner wrote: > From: Dave Chinner > > Write_buf/write_index use confusing boolean values for return, > meaning that it's hard to tell what the correct error return is > supposed to be. Convert them to return zero on success or a > negative errno otherwise so that it's clear what the error case is. > > Signed-off-by: Dave Chinner > --- Looks like this patch broke metadumps on some corrupted filesystems. This is a legacy filesystem that has zeroes overwriting the SB/AGF/AGI on AG 1/2/3: # xfs_metadump -wgo /dev/sda8 myfile.metadata xfs_agf_read_verify: XFS_CORRUPTION_ERROR xfs_metadump: cannot init perag data (117). Continuing anyway. Copied 64 of 64 inodes (0 of 4 AGs) xfs_agf_write_verify: XF S_CORRUPTION_ERROR write_buf: write verifer failed on bno 0x1100919/0x200 (no output) commit dd9093de944cd802427bd42953ad5ccc1d5fb875 before it: # xfs_metadump -wgo /dev/sda8 myfile.metadata xfs_agf_read_verify: XFS_CORRUPTION_ERROR xfs_metadump: cannot init perag data (117). Continuing anyway. Copied 64 of 64 inodes (0 of 4 AGs) xfs_agf_write_verify: XF S_CORRUPTION_ERROR write_buf: write verifer failed on bno 0x1100919/0x200 Copying free space trees of AG 1 xfs_metadump: invalid block number (0) in bnobt root in agf 1 xfs_metadump: invalid block number (0) in cntbt root in agf 1 xfs_metadump: invalid block number (0) in inobt root in agi 1 Copying free space trees of AG 2 xfs_metadump: invalid block number (0) in bnobt root in agf 2 xfs_metadump: invalid block number (0) in cntbt root in agf 2 xfs_metadump: invalid block number (0) in inobt root in agi 2 Copying free space trees of AG 3 xfs_metadump: invalid block number (4294967295) in bnobt root in agf 3 xfs_metadump: invalid block number (4294967295) in cntbt root in agf 3 xfs_metadump: invalid block number (0) in inobt root in agi 3 Copying log _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs