From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <xfs-bounces@oss.sgi.com>
Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111])
	by oss.sgi.com (Postfix) with ESMTP id 3004E7F52
	for <xfs@oss.sgi.com>; Mon, 24 Feb 2014 05:04:29 -0600 (CST)
Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25])
	by relay1.corp.sgi.com (Postfix) with ESMTP id 1D0CC8F8035
	for <xfs@oss.sgi.com>; Mon, 24 Feb 2014 03:04:25 -0800 (PST)
Received: from song.cn.fujitsu.com (cn.fujitsu.com [222.73.24.84]) by
	cuda.sgi.com with ESMTP id HSwmuTzn9nfKKvdd for
	<xfs@oss.sgi.com>; Mon, 24 Feb 2014 03:04:23 -0800 (PST)
Message-ID: <530B26C9.9060606@cn.fujitsu.com>
Date: Mon, 24 Feb 2014 19:02:33 +0800
From: Wang Shilong <wangsl.fnst@cn.fujitsu.com>
MIME-Version: 1.0
Subject: Re: [PATCH for xfstests] xfstests: fix to make tests/btrfs/013 really
	work
References: <530AF3E3.9060202@huawei.com> <530B2418.20905@huawei.com>
In-Reply-To: <530B2418.20905@huawei.com>
List-Id: XFS Filesystem from SGI <xfs.oss.sgi.com>
List-Unsubscribe: <http://oss.sgi.com/mailman/options/xfs>,
	<mailto:xfs-request@oss.sgi.com?subject=unsubscribe>
List-Archive: <http://oss.sgi.com/pipermail/xfs>
List-Post: <mailto:xfs@oss.sgi.com>
List-Help: <mailto:xfs-request@oss.sgi.com?subject=help>
List-Subscribe: <http://oss.sgi.com/mailman/listinfo/xfs>,
	<mailto:xfs-request@oss.sgi.com?subject=subscribe>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: xfs-bounces@oss.sgi.com
Sender: xfs-bounces@oss.sgi.com
To: ZhangZhen <zhenzhang.zhang@huawei.com>
Cc: linux-btrfs@vger.kernel.org, xfs@oss.sgi.com

Hi Zhang,

On 02/24/2014 06:51 PM, ZhangZhen wrote:
> The test 013 couldn't work because here lacked "start".
> This patch fix it.
>
> Signed-off-by: Zhang Zhen<zhenzhang.zhang@huawei.com>
> ---
>   tests/btrfs/013 | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/btrfs/013 b/tests/btrfs/013
> index 7620fcc..fb81663 100644
> --- a/tests/btrfs/013
> +++ b/tests/btrfs/013
> @@ -72,7 +72,7 @@ _check_csum_error()
>   }
>   $XFS_IO_PROG -f -c "falloc 0 1M" -c "pwrite 16k 8k" -c "fsync" \
>   	$SCRATCH_MNT/foo > $seqres.full 2>&1
> -$BTRFS_UTIL_PROG filesystem balance $SCRATCH_MNT >> $seqres.full 2>&1 || \
> +$BTRFS_UTIL_PROG filesystem balance start $SCRATCH_MNT >> $seqres.full 2>&1 || \
>   	_fail "balance failed"
Due to historical reasons, we have 'btrfs file balance <>'.. Until now, 
it is also
ok to run 'btrfs file balance <mnt>', and it has equal effect as 'btrfs 
filesystem balance start'.

Anyway, using latest 'btrfs file balance start <mnt>' is better than 
previous codes..but patch's
title is not right any more...

BTW,Dave Chinner previously pointed out that we need a cleanup, url can 
be seen:

http://oss.sgi.com/archives/xfs/2014-02/msg00482.html

Thanks,
Wang
>   _scratch_unmount
>   _scratch_mount

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs