* [PATCH] xfs_metadump: include F in getopts string
@ 2014-02-25 16:23 Eric Sandeen
2014-02-25 17:36 ` Mark Tinguely
2014-02-25 22:03 ` Christoph Hellwig
0 siblings, 2 replies; 3+ messages in thread
From: Eric Sandeen @ 2014-02-25 16:23 UTC (permalink / raw)
To: xfs-oss; +Cc: Boris Ranto
I added an F case, but didn't add it to the bash
getopts string last go-round.
/usr/sbin/xfs_metadump: illegal option -- F
I sure thought I tested this, I'm not sure how it got lost.
Reported-by: Boris Ranto <branto@redhat.com>
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
diff --git a/db/xfs_metadump.sh b/db/xfs_metadump.sh
index 7ce7a6d..71f579d 100755
--- a/db/xfs_metadump.sh
+++ b/db/xfs_metadump.sh
@@ -7,7 +7,7 @@ OPTS=" "
DBOPTS=" "
USAGE="Usage: xfs_metadump [-efFogwV] [-m max_extents] [-l logdev] source target"
-while getopts "efgl:m:owV" c
+while getopts "efgl:m:owFV" c
do
case $c in
e) OPTS=$OPTS"-e ";;
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] xfs_metadump: include F in getopts string
2014-02-25 16:23 [PATCH] xfs_metadump: include F in getopts string Eric Sandeen
@ 2014-02-25 17:36 ` Mark Tinguely
2014-02-25 22:03 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Mark Tinguely @ 2014-02-25 17:36 UTC (permalink / raw)
To: Eric Sandeen; +Cc: Boris Ranto, xfs-oss
On 02/25/14 10:23, Eric Sandeen wrote:
> I added an F case, but didn't add it to the bash
> getopts string last go-round.
>
> /usr/sbin/xfs_metadump: illegal option -- F
>
> I sure thought I tested this, I'm not sure how it got lost.
>
> Reported-by: Boris Ranto<branto@redhat.com>
> Signed-off-by: Eric Sandeen<sandeen@redhat.com>
> ---
>
> diff --git a/db/xfs_metadump.sh b/db/xfs_metadump.sh
> index 7ce7a6d..71f579d 100755
> --- a/db/xfs_metadump.sh
> +++ b/db/xfs_metadump.sh
> @@ -7,7 +7,7 @@ OPTS=" "
> DBOPTS=" "
> USAGE="Usage: xfs_metadump [-efFogwV] [-m max_extents] [-l logdev] source target"
>
> -while getopts "efgl:m:owV" c
> +while getopts "efgl:m:owFV" c
> do
> case $c in
> e) OPTS=$OPTS"-e ";;
Looks good.
Reviewed-by: Mark Tinguely <tinguely@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xfs_metadump: include F in getopts string
2014-02-25 16:23 [PATCH] xfs_metadump: include F in getopts string Eric Sandeen
2014-02-25 17:36 ` Mark Tinguely
@ 2014-02-25 22:03 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2014-02-25 22:03 UTC (permalink / raw)
To: Eric Sandeen; +Cc: Boris Ranto, xfs-oss
On Tue, Feb 25, 2014 at 10:23:13AM -0600, Eric Sandeen wrote:
> I added an F case, but didn't add it to the bash
> getopts string last go-round.
>
> /usr/sbin/xfs_metadump: illegal option -- F
>
> I sure thought I tested this, I'm not sure how it got lost.
Well, better write a test for xfstests so that we can test it as part of
the regression test run.
Otherwise:
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-02-25 22:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-25 16:23 [PATCH] xfs_metadump: include F in getopts string Eric Sandeen
2014-02-25 17:36 ` Mark Tinguely
2014-02-25 22:03 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox