Re: [PATCH] xfs_metadump: include F in getopts string

Mark Tinguely
2014-02-25T17:36:08Z

On 02/25/14 10:23, Eric Sandeen wrote:
> I added an F case, but didn't add it to the bash
> getopts string last go-round.
>
> /usr/sbin/xfs_metadump: illegal option -- F
>
> I sure thought I tested this, I'm not sure how it got lost.
>
> Reported-by: Boris Ranto<branto@redhat.com>
> Signed-off-by: Eric Sandeen<sandeen@redhat.com>
> ---
>
> diff --git a/db/xfs_metadump.sh b/db/xfs_metadump.sh
> index 7ce7a6d..71f579d 100755
> --- a/db/xfs_metadump.sh
> +++ b/db/xfs_metadump.sh
> @@ -7,7 +7,7 @@ OPTS=" "
> DBOPTS=" "
> USAGE="Usage: xfs_metadump [-efFogwV] [-m max_extents] [-l logdev] source target"
>
> -while getopts "efgl:m:owV" c
> +while getopts "efgl:m:owFV" c
> do
> case $c in
> e) OPTS=$OPTS"-e ";;

Looks good.

Reviewed-by: Mark Tinguely <tinguely@sgi.com>