public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: sat <takeuchi_satoru@jp.fujitsu.com>
To: Dave Chinner <david@fromorbit.com>
Cc: Rob Landley <rob@landley.net>, xfs@oss.sgi.com
Subject: Re: [PATCH] XFS: fix the description of 'allocsize=' mount option
Date: Wed, 26 Feb 2014 13:38:59 +0900	[thread overview]
Message-ID: <530D6FE3.2040406@jp.fujitsu.com> (raw)
In-Reply-To: <20140224120629.GN4317@dastard>

Hi Dave,

> Actually, it isn't. The initial size of dynamic prealloc is
> determined by a set of heuristics based on file size, filesystem
> geometry and the existing extents on the file. It uses a default
> of 64k if no optimisation heuristics trigger.

I see. I should have read the code more carefully.

---
From: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>
Subject: [PATCH] XFS: remove the description about the default value of "allocsize=" mount option

The end-of-file preallocation size is dynamic by default.
So there is no static default size specified by "allocsize="
mount option and the description about the default size
should be removed.

Signed-off-by: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>
Cc: Dave Chinner <david@fromorbit.com>
Cc: Rob Landley <rob@landley.net>
---
  Documentation/filesystems/xfs.txt |    6 +++---
  1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/Documentation/filesystems/xfs.txt b/Documentation/filesystems/xfs.txt
index 5be51fd..5837f0a 100644
--- a/Documentation/filesystems/xfs.txt
+++ b/Documentation/filesystems/xfs.txt
@@ -23,9 +23,9 @@ default behaviour.
  
    allocsize=size
      Sets the buffered I/O end-of-file preallocation size when
-    doing delayed allocation writeout (default size is 64KiB).
-    Valid values for this option are page size (typically 4KiB)
-    through to 1GiB, inclusive, in power-of-2 increments.
+    doing delayed allocation writeout. Valid values for this
+    option are page size (typically 4KiB) through to 1GiB,
+    inclusive, in power-of-2 increments.
  
      The default behaviour is for dynamic end-of-file
      preallocation size, which uses a set of heuristics to
-- 
1.7.1



_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2014-02-26  4:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-24  6:04 [PATCH] XFS: fix the description of 'allocsize=' mount option sat
2014-02-24 12:06 ` Dave Chinner
2014-02-26  4:38   ` sat [this message]
2014-02-27  6:42     ` Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=530D6FE3.2040406@jp.fujitsu.com \
    --to=takeuchi_satoru@jp.fujitsu.com \
    --cc=david@fromorbit.com \
    --cc=rob@landley.net \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox