From: Eric Sandeen <sandeen@sandeen.net>
To: Eric Sandeen <sandeen@redhat.com>, xfs-oss <xfs@oss.sgi.com>
Subject: [PATCH 2/2] xfs_logprint: don't advance op counter in xlog_print_trans_icreate
Date: Wed, 26 Feb 2014 19:15:52 -0600 [thread overview]
Message-ID: <530E91C8.1010207@sandeen.net> (raw)
In-Reply-To: <530E8E17.1090901@redhat.com>
xlog_print_trans_icreate is advancing the op counter
"(*i)++" incorrectly; it only contains one region, and
the loop which called it will properly advance the op
once we're done.
Found-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
diff --git a/logprint/log_misc.c b/logprint/log_misc.c
index 7070fa3..52f1e85 100644
--- a/logprint/log_misc.c
+++ b/logprint/log_misc.c
@@ -810,7 +810,6 @@ xlog_print_trans_icreate(
memmove(&icl_buf, *ptr, MIN(sizeof(struct xfs_icreate_log), len));
icl = &icl_buf;
- (*i)++;
*ptr += len;
/* handle complete header only */
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-02-27 1:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-27 1:00 [PATCH 0/2] xfs_logprint: Get xfstests/xfs/295 passing w/ CRCs Eric Sandeen
2014-02-27 1:13 ` [PATCH 1/2] xfs_logprint: Don't error out after split items lose context Eric Sandeen
2014-02-27 1:27 ` Dave Chinner
2014-02-27 1:15 ` Eric Sandeen [this message]
2014-02-27 1:28 ` [PATCH 2/2] xfs_logprint: don't advance op counter in xlog_print_trans_icreate Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530E91C8.1010207@sandeen.net \
--to=sandeen@sandeen.net \
--cc=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox