* [PATCH] xfs_io: add missing break in O_TMPFILE case
@ 2014-02-27 20:16 Eric Sandeen
2014-02-27 20:21 ` Christoph Hellwig
2014-02-27 20:25 ` Dave Chinner
0 siblings, 2 replies; 3+ messages in thread
From: Eric Sandeen @ 2014-02-27 20:16 UTC (permalink / raw)
To: xfs-oss
Coverity spotted this.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
(I assume that -T isn't supposed to imply -x?)
diff --git a/io/init.c b/io/init.c
index fd1a52f..1e2690e 100644
--- a/io/init.c
+++ b/io/init.c
@@ -181,6 +181,7 @@ init(
break;
case 'T':
flags |= IO_TMPFILE;
+ break;
case 'x':
expert = 1;
break;
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] xfs_io: add missing break in O_TMPFILE case
2014-02-27 20:16 [PATCH] xfs_io: add missing break in O_TMPFILE case Eric Sandeen
@ 2014-02-27 20:21 ` Christoph Hellwig
2014-02-27 20:25 ` Dave Chinner
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2014-02-27 20:21 UTC (permalink / raw)
To: Eric Sandeen; +Cc: xfs-oss
On Thu, Feb 27, 2014 at 02:16:49PM -0600, Eric Sandeen wrote:
> Coverity spotted this.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
>
> (I assume that -T isn't supposed to imply -x?)
It's not, thanks!
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xfs_io: add missing break in O_TMPFILE case
2014-02-27 20:16 [PATCH] xfs_io: add missing break in O_TMPFILE case Eric Sandeen
2014-02-27 20:21 ` Christoph Hellwig
@ 2014-02-27 20:25 ` Dave Chinner
1 sibling, 0 replies; 3+ messages in thread
From: Dave Chinner @ 2014-02-27 20:25 UTC (permalink / raw)
To: Eric Sandeen; +Cc: xfs-oss
On Thu, Feb 27, 2014 at 02:16:49PM -0600, Eric Sandeen wrote:
> Coverity spotted this.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
>
> (I assume that -T isn't supposed to imply -x?)
>
> diff --git a/io/init.c b/io/init.c
> index fd1a52f..1e2690e 100644
> --- a/io/init.c
> +++ b/io/init.c
> @@ -181,6 +181,7 @@ init(
> break;
> case 'T':
> flags |= IO_TMPFILE;
> + break;
> case 'x':
> expert = 1;
> break;
Looks good.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-02-27 20:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-27 20:16 [PATCH] xfs_io: add missing break in O_TMPFILE case Eric Sandeen
2014-02-27 20:21 ` Christoph Hellwig
2014-02-27 20:25 ` Dave Chinner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox