From: Eric Sandeen <sandeen@sandeen.net>
To: xfs-oss <xfs@oss.sgi.com>
Subject: [PATCH] xfs_db: hide debug bbmap output
Date: Tue, 11 Mar 2014 11:04:04 -0500 [thread overview]
Message-ID: <531F33F4.40707@sandeen.net> (raw)
Most of xfsprogs building with DEBUG enables extra
checks, asserts, etc, but this bunch of printfs was
extra output that's not generally helpful for most
people's runtime experience - and it breaks xfs/290
with all the noise.
I assume it's for actual debugging use, and not
generally useful, so bury it a bit deeper under
it's own #ifdef.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
diff --git a/db/io.c b/db/io.c
index 9a787c8..89e6030 100644
--- a/db/io.c
+++ b/db/io.c
@@ -500,7 +500,7 @@ set_cur(
push_cur();
if (bbmap) {
-#ifdef DEBUG
+#ifdef DEBUG_BBMAP
int i;
printf(_("xfs_db got a bbmap for %lld\n"), (long long)d);
printf(_("\tblock map"));
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next reply other threads:[~2014-03-11 16:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-11 16:04 Eric Sandeen [this message]
2014-03-11 22:51 ` [PATCH] xfs_db: hide debug bbmap output Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=531F33F4.40707@sandeen.net \
--to=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox