[PATCH] xfs_db: hide debug bbmap output

[PATCH] xfs_db: hide debug bbmap output

[Eric Sandeen]

Most of xfsprogs building with DEBUG enables extra
checks, asserts, etc, but this bunch of printfs was
extra output that's not generally helpful for most
people's runtime experience - and it breaks xfs/290
with all the noise.

I assume it's for actual debugging use, and not
generally useful, so bury it a bit deeper under
it's own #ifdef.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---

diff --git a/db/io.c b/db/io.c
index 9a787c8..89e6030 100644
--- a/db/io.c
+++ b/db/io.c
@@ -500,7 +500,7 @@ set_cur(
 	push_cur();
 
 	if (bbmap) {
-#ifdef DEBUG
+#ifdef DEBUG_BBMAP
 		int i;
 		printf(_("xfs_db got a bbmap for %lld\n"), (long long)d);
 		printf(_("\tblock map"));

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfs_db: hide debug bbmap output

[Dave Chinner]

On Tue, Mar 11, 2014 at 11:04:04AM -0500, Eric Sandeen wrote:
> Most of xfsprogs building with DEBUG enables extra
> checks, asserts, etc, but this bunch of printfs was
> extra output that's not generally helpful for most
> people's runtime experience - and it breaks xfs/290
> with all the noise.
> 
> I assume it's for actual debugging use, and not
> generally useful, so bury it a bit deeper under
> it's own #ifdef.
> 
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>

Just remove it, I think. It doesn't serve any real purpose anymore,
and changing it to an obscure ifdef guarantees it'll never get used
again...

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs