From: Jeff Liu <jeff.liu@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: "xfs@oss.sgi.com" <xfs@oss.sgi.com>
Subject: Re: [PATCH v2] xfstests: shared/051: add filter to match the golden output for large acls
Date: Thu, 13 Mar 2014 07:13:36 +0800 [thread overview]
Message-ID: <5320EA20.7000807@oracle.com> (raw)
In-Reply-To: <20140312103230.GA4167@infradead.org>
On 03/12 2014 18:32 PM, Christoph Hellwig wrote:
>> +# we return E2BIG if hit the max acl limits on new kernel, but EINVAL
>> +# on old kernel. So we need to filter the error message out in order
>> +# to make the current golden output works for both old and new kernels.
>
> Hate to nitpick, but shouldn't the new one be in the golden output and
> the old one fixed up?
Exactly, I'll post a fix.
Thanks,
-Jeff
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2014-03-12 23:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-12 2:03 [PATCH v2] xfstests: shared/051: add filter to match the golden output for large acls Jeff Liu
2014-03-12 10:32 ` Christoph Hellwig
2014-03-12 23:13 ` Jeff Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5320EA20.7000807@oracle.com \
--to=jeff.liu@oracle.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).