From: Mark Tinguely <tinguely@sgi.com>
To: Hannes Frederic Sowa <hannes@stressinduktion.org>
Cc: xfs@oss.sgi.com
Subject: Re: xfs errors while unlinking filenames with hash collisions
Date: Thu, 27 Mar 2014 16:20:44 -0500 [thread overview]
Message-ID: <5334962C.1050501@sgi.com> (raw)
In-Reply-To: <20140327211514.GF29498@order.stressinduktion.org>
On 03/27/14 16:15, Hannes Frederic Sowa wrote:
> On Thu, Mar 27, 2014 at 03:57:45PM -0500, Mark Tinguely wrote:
>> On 03/27/14 10:24, Hannes Frederic Sowa wrote:
>>> On Thu, Mar 27, 2014 at 10:15:01AM -0500, Mark Tinguely wrote:
>>>> On 03/27/14 09:05, Hannes Frederic Sowa wrote:
>>>>> On Thu, Mar 27, 2014 at 08:34:14AM -0500, Mark Tinguely wrote:
>>>>>> On 03/27/14 08:23, Hannes Frederic Sowa wrote:
>>>>>>> On Thu, Mar 27, 2014 at 08:14:06AM -0500, Mark Tinguely wrote:
>>>>>>>> Have you tried to run a xfs_repair on the filesystem after the reboot?
>>>>>>>
>>>>>>> Yes, I did. I still use the filesystem and it works. As soon as I try
>>>>>>> to
>>>>>>> remove the directory again the same splash from above happens again.
>>>>>>
>>>>>> Is it the latest xfsprogs' repair?
>>>>>>
>>>>>> Do you have the output from the repair still?
>>>>>
>>>>> I can easily test this here, so you can throw any commands and tests at
>>>>> me. ;)
>>>>>
>>>>> This is the output:
>>>>>
>>>>> (I replayed the journal before that)
>>>>>
>>>>> pre-mount:/# xfs_repair -V
>>>>> xfs_repair version 3.1.11
>>>>> pre-mount:/# xfs_repair -v /dev/vda1
>>>>> Phase 1 - find and verify superblock...
>>>>> - block cache size set to 372848 entries
>>>>> Phase 2 - using internal log
>>>>> - zero log...
>>>>> zero_log: head block 5071 tail block 5071
>>>>> - scan filesystem freespace and inode maps...
>>>>> - found root inode chunk
>>>>> Phase 3 - for each AG...
>>>>> - scan and clear agi unlinked lists...
>>>>> - process known inodes and perform inode discovery...
>>>>> - agno = 0
>>>>> bad hash ordering in block 8388739 of directory inode 3543184
>>>>
>>>> interesting. I will see if I can recreate it.
>>>>
>>>> Are you open to making it an xfstest?
>>>
>>> Sure, I'll put it on my todo list for the weekend.
>>>
>> I will bisect to find the introduction. It appears be somewhere between
>> Linux 3.9 and 3.10.
>
> Thanks!
>
> Maybe it would be best to add a seed to the hashing function (and the super
> block)?
>
Good idea - replicate a test like fsstress.
I bet you could narrow down the iterations required to cause the hang.
I have been using wall clock and disk blocks used as a guide so far.
--Mark.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-03-27 21:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-27 7:41 xfs errors while unlinking filenames with hash collisions Hannes Frederic Sowa
2014-03-27 13:14 ` Mark Tinguely
2014-03-27 13:23 ` Hannes Frederic Sowa
2014-03-27 13:34 ` Mark Tinguely
2014-03-27 14:05 ` Hannes Frederic Sowa
2014-03-27 15:15 ` Mark Tinguely
2014-03-27 15:24 ` Hannes Frederic Sowa
2014-03-27 20:36 ` Mark Tinguely
2014-03-27 20:57 ` Mark Tinguely
2014-03-27 21:15 ` Hannes Frederic Sowa
2014-03-27 21:20 ` Mark Tinguely [this message]
2014-04-01 18:49 ` [PATCH xfstests] tests for file hash collisions on xfs filesystems Hannes Frederic Sowa
2014-04-01 18:56 ` Mark Tinguely
2014-04-01 23:03 ` [PATCH v2 xfstests] add tests for unlinking directories with hash collisions Hannes Frederic Sowa
2014-04-02 12:34 ` [PATCH v3 " Hannes Frederic Sowa
2014-04-02 13:07 ` Mark Tinguely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5334962C.1050501@sgi.com \
--to=tinguely@sgi.com \
--cc=hannes@stressinduktion.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).