From: Mark Tinguely <tinguely@sgi.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] libxfs: remove never-read "offset" assignment in readbufr_map & writebufr
Date: Wed, 09 Apr 2014 15:59:25 -0500 [thread overview]
Message-ID: <5345B4AD.1080508@sgi.com> (raw)
In-Reply-To: <53459D9A.1040707@sandeen.net>
On 04/09/14 14:20, Eric Sandeen wrote:
> libxfs_readbufr_map()& libxfs_writebufr() iterate
> over bp->b_map[] and read each chunk. The loops start
> out correctly, getting the offset from bm_bn and the
> length from bm_len. After the IO it correctly
> advances the target buffer pointer by len, but then
> inexplicably advances "offset" by len as well. The
> whole point of this exercise is to handle discontiguous
> ranges - marching offset along by length of IO done
> is incorrect.
>
> Thankfully offset is immediately reset to the proper
> value again at the top of the loop for the next range,
> so this is harmless, other than being confusing.
>
> Signed-off-by: Eric Sandeen<sandeen@redhat.com>
Looks good.
Reviewed-by: Mark Tinguely <tinguely@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2014-04-09 20:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-09 19:20 [PATCH] libxfs: remove never-read "offset" assignment in readbufr_map & writebufr Eric Sandeen
2014-04-09 20:59 ` Mark Tinguely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5345B4AD.1080508@sgi.com \
--to=tinguely@sgi.com \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).