From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id BAFCC8001 for ; Wed, 9 Apr 2014 16:34:24 -0500 (CDT) Message-ID: <5345BCE1.7070900@sgi.com> Date: Wed, 09 Apr 2014 16:34:25 -0500 From: Mark Tinguely MIME-Version: 1.0 Subject: Re: [PATCH] xfs: remove pointless pointer increment in xfs_dir2_block_compact() References: <5345ADF9.2030402@redhat.com> In-Reply-To: <5345ADF9.2030402@redhat.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Eric Sandeen Cc: xfs-oss On 04/09/14 15:30, Eric Sandeen wrote: > xfs_dir2_block_compact() is passed a pointer to *blp, and > advances it locally - but nobody uses the pointer (locally) > after that. > > This behavior came about as part of prior refactoring, > > 20f7e9f xfs: factor dir2 block read operations > > and looking at the code as it was before, it seems quite clear > that this change introduced a bug; the pre-refactoring code > expects blp to be modified after compaction. > And indeed it did; see this commit which fixed it: > > 37f1356 xfs: recalculate leaf entry pointer after compacting a dir2 block > > So the bug was introduced & resolved in the 3.8 cycle. > > Whoops. Well, it's fixed now, and mystery solved; just remove > the now-pointless local increment of the blp pointer. > > (I guess we should have run clang earlier!) > > Signed-off-by: Eric Sandeen > --- Harmless, but yes it should be removed. Reviewed-by: Mark Tinguely _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs