From: Eric Sandeen <sandeen@redhat.com>
To: Mark Tinguely <tinguely@sgi.com>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfs: remove pointless pointer increment in xfs_dir2_block_compact()
Date: Wed, 09 Apr 2014 16:35:33 -0500 [thread overview]
Message-ID: <5345BD25.4060203@redhat.com> (raw)
In-Reply-To: <5345BCE1.7070900@sgi.com>
On 4/9/14, 4:34 PM, Mark Tinguely wrote:
> On 04/09/14 15:30, Eric Sandeen wrote:
>> xfs_dir2_block_compact() is passed a pointer to *blp, and
>> advances it locally - but nobody uses the pointer (locally)
>> after that.
>>
>> This behavior came about as part of prior refactoring,
>>
>> 20f7e9f xfs: factor dir2 block read operations
>>
>> and looking at the code as it was before, it seems quite clear
>> that this change introduced a bug; the pre-refactoring code
>> expects blp to be modified after compaction.
>> And indeed it did; see this commit which fixed it:
>>
>> 37f1356 xfs: recalculate leaf entry pointer after compacting a dir2 block
>>
>> So the bug was introduced & resolved in the 3.8 cycle.
>>
>> Whoops. Well, it's fixed now, and mystery solved; just remove
>> the now-pointless local increment of the blp pointer.
>>
>> (I guess we should have run clang earlier!)
>>
>> Signed-off-by: Eric Sandeen<sandeen@redhat.com>
>> ---
>
> Harmless, but yes it should be removed.
Harmless now that we fixed it the hard way back in January... ;)
thanks for the reviews,
-Eric
> Reviewed-by: Mark Tinguely <tinguely@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2014-04-09 21:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-09 20:30 [PATCH] xfs: remove pointless pointer increment in xfs_dir2_block_compact() Eric Sandeen
2014-04-09 21:34 ` Mark Tinguely
2014-04-09 21:35 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5345BD25.4060203@redhat.com \
--to=sandeen@redhat.com \
--cc=tinguely@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).