[PATCH] xfstests: log running test to dmesg

[PATCH] xfstests: log running test to dmesg

[Eric Sandeen]

We already log the running test to system logs via "logger"
but viro pointed out that we can use /dev/kmsg to insert it
into dmesg as well.  When looking at the serial console that
could be pretty useful.

Thanks to viro for the test -w suggestion too.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---

diff --git a/check b/check
index 268417c..09b2320 100755
--- a/check
+++ b/check
@@ -457,6 +457,7 @@ do
 	$timestamp && echo -n "	["`date "+%T"`"]"
 	[ ! -x $seq ] && chmod u+x $seq # ensure we can run it
 	$LOGGER_PROG "run xfstest $seqnum"
+	test -w /dev/kmsg && echo "run xfstest $seqnum" > /dev/kmsg
 	./$seq >$tmp.rawout 2>&1
 	sts=$?
 	$timestamp && _timestamp


_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfstests: log running test to dmesg

[Dave Chinner]

On Wed, Apr 16, 2014 at 04:37:33PM -0500, Eric Sandeen wrote:
> We already log the running test to system logs via "logger"
> but viro pointed out that we can use /dev/kmsg to insert it
> into dmesg as well.  When looking at the serial console that
> could be pretty useful.
> 
> Thanks to viro for the test -w suggestion too.
> 
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
> 
> diff --git a/check b/check
> index 268417c..09b2320 100755
> --- a/check
> +++ b/check
> @@ -457,6 +457,7 @@ do
>  	$timestamp && echo -n "	["`date "+%T"`"]"
>  	[ ! -x $seq ] && chmod u+x $seq # ensure we can run it
>  	$LOGGER_PROG "run xfstest $seqnum"
> +	test -w /dev/kmsg && echo "run xfstest $seqnum" > /dev/kmsg
>  	./$seq >$tmp.rawout 2>&1
>  	sts=$?
>  	$timestamp && _timestamp

Might it be worthwhile adding a "_log" function that can take an
arbitrary string so in future it is easy to add new log messages?

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfstests: log running test to dmesg

[Eric Sandeen]

On 4/16/14, 6:40 PM, Dave Chinner wrote:
> On Wed, Apr 16, 2014 at 04:37:33PM -0500, Eric Sandeen wrote:
>> We already log the running test to system logs via "logger"
>> but viro pointed out that we can use /dev/kmsg to insert it
>> into dmesg as well.  When looking at the serial console that
>> could be pretty useful.
>>
>> Thanks to viro for the test -w suggestion too.
>>
>> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
>> ---
>>
>> diff --git a/check b/check
>> index 268417c..09b2320 100755
>> --- a/check
>> +++ b/check
>> @@ -457,6 +457,7 @@ do
>>  	$timestamp && echo -n "	["`date "+%T"`"]"
>>  	[ ! -x $seq ] && chmod u+x $seq # ensure we can run it
>>  	$LOGGER_PROG "run xfstest $seqnum"
>> +	test -w /dev/kmsg && echo "run xfstest $seqnum" > /dev/kmsg
>>  	./$seq >$tmp.rawout 2>&1
>>  	sts=$?
>>  	$timestamp && _timestamp
> 
> Might it be worthwhile adding a "_log" function that can take an
> arbitrary string so in future it is easy to add new log messages?

*shrug* I guess... nobody logs anything but here, today...

-Eric
 
> Cheers,
> 
> Dave.
> 

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfstests: log running test to dmesg

[Eric Sandeen]

On 4/16/14, 4:37 PM, Eric Sandeen wrote:
> We already log the running test to system logs via "logger"
> but viro pointed out that we can use /dev/kmsg to insert it
> into dmesg as well.  When looking at the serial console that
> could be pretty useful.
> 
> Thanks to viro for the test -w suggestion too.
> 
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>

can we get this one in?  Dave asked for a generic helper, but
no test needs to print to kmsg, and nobody else uses LOGGER_PROG.

All we use either one for is logging the test run.

If somebody needs it for another purpose, it makes sense to add a
helper...

-Eric

> ---
> 
> diff --git a/check b/check
> index 268417c..09b2320 100755
> --- a/check
> +++ b/check
> @@ -457,6 +457,7 @@ do
>  	$timestamp && echo -n "	["`date "+%T"`"]"
>  	[ ! -x $seq ] && chmod u+x $seq # ensure we can run it
>  	$LOGGER_PROG "run xfstest $seqnum"
> +	test -w /dev/kmsg && echo "run xfstest $seqnum" > /dev/kmsg
>  	./$seq >$tmp.rawout 2>&1
>  	sts=$?
>  	$timestamp && _timestamp
> 
> 
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
> 

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs