From: Jeff Liu <jeff.liu@oracle.com>
To: Konstantin Khlebnikov <k.khlebnikov@samsung.com>, xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: generic/285: fix seek_sanity_test for generic SEEK_HOLE/DATA
Date: Tue, 22 Apr 2014 11:56:47 +0800 [thread overview]
Message-ID: <5355E87F.8030906@oracle.com> (raw)
In-Reply-To: <20140421164305.22404.92195.stgit@buzz>
On 04/22 2014 00:43 AM, Konstantin Khlebnikov wrote:
> Generic implementation of SEEK_HOLE/DATA reports whole file as data chunk with
> virtual hole at the end (generic_file_llseek, used by ext2/ext3/reiserfs/nfs).
>
> Currently test prepares file smaller than expected for "huge file" testcases
> (testcases 10-12). This patch fixes test file layout, now second data chunk
> ends right at the expected end of file.
>
> Plus it fixes type of 'filesz' argument, it should be off_t.
Am not verified against NFS, but the fix look good to me.
Thanks,
-Jeff
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2014-04-22 3:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-21 16:43 [PATCH] xfstests: generic/285: fix seek_sanity_test for generic SEEK_HOLE/DATA Konstantin Khlebnikov
2014-04-22 3:56 ` Jeff Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5355E87F.8030906@oracle.com \
--to=jeff.liu@oracle.com \
--cc=k.khlebnikov@samsung.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).