From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id 083087F52 for ; Thu, 24 Apr 2014 15:59:32 -0500 (CDT) Message-ID: <53597B34.9050407@sgi.com> Date: Thu, 24 Apr 2014 15:59:32 -0500 From: Mark Tinguely MIME-Version: 1.0 Subject: Re: [RFC] libxfs: adding attribute fork frees xfs_inode ptr References: <20140423210034.892939354@sgi.com> <20140423210445.700477624@sgi.com> <20140423222215.GT18672@dastard> <535945DC.6010108@sgi.com> In-Reply-To: <535945DC.6010108@sgi.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: XFS Mailing List On 04/24/14 12:11, Mark Tinguely wrote: > On 04/23/14 17:22, Dave Chinner wrote: >> On Wed, Apr 23, 2014 at 04:04:35PM -0500, Mark Tinguely wrote: ... Note that libxfs still has libxfs_trans_ijoin_ref() which sets the >> lock flags, but this has been removed from the kernel code. IOWs, >> this is a libxfs/trans.c::xfs_trans_ijoin() bug, not something that >> needs fixing in the shared kernel/user libxfs code. >> >> Cheers, >> >> Dave. > > nod. That is the correct thing to do. > > Since the shared user/kernel code will no longer do a xfs_trans_ihold(), > the libxfs_iput() should be factored out out of inode_item_unlock() and > have the creator release the inode pointer when it is appropriate. > > No one besides me is using this so it can go into the next release of > xfs_progs. > > --Mark. PS. I may not have been very clear, the libxfs_trans_roll() and inode_item_done() also cause a premature libxfs_iput(). Let me do more testing making any changes and target this for xfsprogs-3.2.1. --Mark. _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs