From: Mark Tinguely <tinguely@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: XFS Mailing List <xfs@oss.sgi.com>
Subject: Re: [RFC] libxfs: adding attribute fork frees xfs_inode ptr
Date: Fri, 25 Apr 2014 08:18:11 -0500 [thread overview]
Message-ID: <535A6093.8060005@sgi.com> (raw)
In-Reply-To: <20140425054021.GA16132@infradead.org>
On 04/25/14 00:40, Christoph Hellwig wrote:
> On Thu, Apr 24, 2014 at 03:59:32PM -0500, Mark Tinguely wrote:
>> PS. I may not have been very clear, the libxfs_trans_roll() and
>> inode_item_done() also cause a premature libxfs_iput().
>> Let me do more testing making any changes and target this for
>> xfsprogs-3.2.1.
>
> You mean you've fixed the way we handle the attachement of inodes to
> transaction in userspace to mirror what we do in kernelspace? I'd love
> to review this if you have patches as it's a somewhat of a pain point
> to have these work so different in kernel and userspace.
>
Not yet, I made the changes within the existing code so I can continue
with my project. I agree, the user inode transaction code has to be
synced with the kernel. I will start looking at it this weekend.
--Mark.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2014-04-25 13:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20140423210034.892939354@sgi.com>
2014-04-23 21:04 ` [RFC] libxfs: adding attribute fork frees xfs_inode ptr Mark Tinguely
2014-04-23 22:22 ` Dave Chinner
2014-04-24 17:11 ` Mark Tinguely
2014-04-24 20:59 ` Mark Tinguely
2014-04-25 5:40 ` Christoph Hellwig
2014-04-25 13:18 ` Mark Tinguely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=535A6093.8060005@sgi.com \
--to=tinguely@sgi.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).