From: Jeff Liu <jeff.liu@oracle.com>
To: Brian Foster <bfoster@redhat.com>
Cc: "xfs@oss.sgi.com" <xfs@oss.sgi.com>
Subject: Re: [PATCH 3/6] xfsprogs: get rid of XFS_IALLOC_BLOCKS macros
Date: Tue, 06 May 2014 09:50:54 +0800 [thread overview]
Message-ID: <53683FFE.2080909@oracle.com> (raw)
In-Reply-To: <20140505211009.GD13973@laptop.bfoster>
On 05/06 2014 05:10 AM, Brian Foster wrote:
> On Mon, May 05, 2014 at 08:32:13PM +0800, Jeff Liu wrote:
>> From: Jie Liu <jeff.liu@oracle.com>
>>
>> Get rid of XFS_IALLOC_BLOCKS() macros, use mp->m_ialloc_blks directly.
>>
>> Signed-off-by: Jie Liu <jeff.liu@oracle.com>
>> ---
>> db/check.c | 2 +-
>> db/frag.c | 2 +-
>> db/metadump.c | 2 +-
>> include/xfs_ialloc.h | 5 -----
>> include/xfs_trans_space.h | 2 +-
>> libxfs/xfs_ialloc.c | 8 ++++----
>> libxfs/xfs_trans_resv.c | 8 ++++----
>> mkfs/proto.c | 2 +-
>> repair/dino_chunks.c | 24 ++++++++++++------------
>> repair/prefetch.c | 2 +-
>> repair/xfs_repair.c | 4 ++--
>> 11 files changed, 28 insertions(+), 33 deletions(-)
>>
<snip>
>> diff --git a/mkfs/proto.c b/mkfs/proto.c
>> index 5a47e27..2689f75 100644
>> --- a/mkfs/proto.c
>> +++ b/mkfs/proto.c
>> @@ -39,7 +39,7 @@ static long filesize(int fd);
>> * (basically no fragmentation).
>> */
>> #define MKFS_BLOCKRES_INODE \
>> - ((uint)(XFS_IALLOC_BLOCKS(mp) + ((mp)->m_in_maxlevels - 1)))
>> + ((uint)(mp->m_ialloc_blks + ((mp)->m_in_maxlevels - 1)))
> Nit: (mp)
>
> Probably not necessary here anyways...
Nice catch, thanks for your review.
Cheers,
-Jeff
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2014-05-06 1:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-05 12:32 [PATCH 3/6] xfsprogs: get rid of XFS_IALLOC_BLOCKS macros Jeff Liu
2014-05-05 21:10 ` Brian Foster
2014-05-06 1:50 ` Jeff Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53683FFE.2080909@oracle.com \
--to=jeff.liu@oracle.com \
--cc=bfoster@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox