From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id B9B387F52 for ; Wed, 7 May 2014 22:42:36 -0500 (CDT) Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by relay1.corp.sgi.com (Postfix) with ESMTP id 999928F8037 for ; Wed, 7 May 2014 20:42:33 -0700 (PDT) Received: from heian.cn.fujitsu.com (cn.fujitsu.com [59.151.112.132]) by cuda.sgi.com with ESMTP id iS59zeXbgYOn9QRt for ; Wed, 07 May 2014 20:42:31 -0700 (PDT) Message-ID: <536AFC3B.7070502@cn.fujitsu.com> Date: Thu, 8 May 2014 11:38:35 +0800 From: Wang Shilong MIME-Version: 1.0 Subject: Re: [PATCH v2 1/3] xfstests/btrfs: add qgroup rescan stress test References: <1394423051-17356-1-git-send-email-wangsl.fnst@cn.fujitsu.com> <536A9E73.90802@fb.com> In-Reply-To: <536A9E73.90802@fb.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Josef Bacik Cc: linux-btrfs@vger.kernel.org, xfs@oss.sgi.com On 05/08/2014 04:58 AM, Josef Bacik wrote: > On 03/09/2014 11:44 PM, Wang Shilong wrote: >> Test flow is to run fsstress after triggering quota rescan. >> the ruler is simple, we just remove all files and directories, >> sync filesystem and see if qgroup's ref and excl are nodesize. >> >> Signed-off-by: Wang Shilong >> --- >> v1->v2: >> switch into new helper _run_btrfs_util_prog() >> --- >> tests/btrfs/041 | 76 >> +++++++++++++++++++++++++++++++++++++++++++++++++++++ >> tests/btrfs/041.out | 3 +++ >> tests/btrfs/group | 1 + >> 3 files changed, 80 insertions(+) >> create mode 100644 tests/btrfs/041 >> create mode 100644 tests/btrfs/041.out >> >> diff --git a/tests/btrfs/041 b/tests/btrfs/041 >> new file mode 100644 >> index 0000000..92bd080 >> --- /dev/null >> +++ b/tests/btrfs/041 >> @@ -0,0 +1,76 @@ >> +#! /bin/bash >> +# FSQA Test No. btrfs/041 >> +# >> +# Quota rescan stress test, we run fsstress and quota rescan >> concurrently >> +# >> +#----------------------------------------------------------------------- >> >> +# Copyright (C) 2014 Fujitsu. All rights reserved. >> +# >> +# This program is free software; you can redistribute it and/or >> +# modify it under the terms of the GNU General Public License as >> +# published by the Free Software Foundation. >> +# >> +# This program is distributed in the hope that it would be useful, >> +# but WITHOUT ANY WARRANTY; without even the implied warranty of >> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> +# GNU General Public License for more details. >> +# >> +# You should have received a copy of the GNU General Public License >> +# along with this program; if not, write the Free Software Foundation, >> +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA >> +# >> +#----------------------------------------------------------------------- >> >> +# >> + >> +seq=`basename $0` >> +seqres=$RESULT_DIR/$seq >> +echo "QA output created by $seq" >> + >> +here=`pwd` >> +tmp=/tmp/$$ >> +status=1 >> + >> +_cleanup() >> +{ >> + cd / >> + rm -f $tmp.* >> +} >> +trap "_cleanup; exit \$status" 0 1 2 3 15 >> + >> +# get standard environment, filters and checks >> +. ./common/rc >> +. ./common/filter >> + >> +# real QA test starts here >> +_need_to_be_root >> +_supported_fs btrfs >> +_supported_os Linux >> +_require_scratch >> + >> +rm -f $seqres.full >> + >> +run_check _scratch_mkfs "-b 1g --nodesize 4096" >> +run_check _scratch_mount >> + > > Add "-o nospace_cache" here please, otherwise I don't get the same > output. I am little confused why we need specify this mount option explicitly? As far as i know, space cache is not included into qgroup accounting space. Thanks, Wang > >> +# -w ensures that the only ops are ones which cause write I/O >> +run_check $FSSTRESS_PROG -d $SCRATCH_MNT -w -p 5 -n 1000 \ >> + $FSSTRESS_AVOID >&/dev/null >> + >> +_run_btrfs_util_prog subvolume snapshot $SCRATCH_MNT \ >> + $SCRATCH_MNT/snap1 >>$seqres.full 2>&1 > > _run_btrfs_util_prog will already redirect to $seqres.full, you don't > need this part. > >> + >> +run_check $FSSTRESS_PROG -d $SCRATCH_MNT/snap1 -w -p 5 -n 1000 \ >> + $FSSTRESS_AVOID >&/dev/null >> + >> +_run_btrfs_util_prog quota enable $SCRATCH_MNT >> +_run_btrfs_util_prog quota rescan -w $SCRATCH_MNT >> + >> +#ignore removing subvolume errors >> +rm -rf $SCRATCH_MNT/* >& /dev/null >> + >> +_run_btrfs_util_prog filesystem sync $SCRATCH_MNT >> $seqres.full 2>&1 > > Same here. > >> +_run_btrfs_util_prog qgroup show $SCRATCH_MNT | $SED_PROG -n >> '/[0-9]/p' \ >> + | $AWK_PROG '{print $1" "$2" "$3 }' >> + > > You can't use _run_btrfs_util_prog here, it will eat the output. You > need to use $BTRFS_UTIL_PROG instead. Fix these up and resend, this > is a really important test and I needed it to make sure my qgroups > patch was right (which it is now.) Thanks, > > Josef > . > _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs