Remove xfs_check for 3.2.0?

Remove xfs_check for 3.2.0?

[Eric Sandeen]

I think we had stated removal in June 2014, but it seems close enough.

Should xfs_check be removed prior to 3.2.0's release?

-Eric

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: Remove xfs_check for 3.2.0?

[Dave Chinner]

On Thu, May 08, 2014 at 01:40:21PM -0500, Eric Sandeen wrote:
> I think we had stated removal in June 2014, but it seems close enough.
> 
> Should xfs_check be removed prior to 3.2.0's release?

I'd prefer to do it slightly later than earlier.

As it is, 3.2.0 is really in the "critical fixes only" stage - like
that repair prefetch bug. So apart from fixes like that, I don't
want to be changing things right now.

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: Remove xfs_check for 3.2.0?

[Eric Sandeen]

On 5/8/14, 3:39 PM, Dave Chinner wrote:
> On Thu, May 08, 2014 at 01:40:21PM -0500, Eric Sandeen wrote:
>> I think we had stated removal in June 2014, but it seems close enough.
>>
>> Should xfs_check be removed prior to 3.2.0's release?
> 
> I'd prefer to do it slightly later than earlier.
> 
> As it is, 3.2.0 is really in the "critical fixes only" stage - like
> that repair prefetch bug. So apart from fixes like that, I don't
> want to be changing things right now.
> 
> Cheers,
> 
> Dave.
> 

*shrug* ok.  Let a thousand "hey my xfs_check OOM'd" emails blossom! :)

FWIW, I did not have time to work on that prefetch bug yet today.  :(

-Eric

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: Remove xfs_check for 3.2.0?

[Emmanuel Florac]

Le Thu, 08 May 2014 15:40:57 -0500 vous écriviez:

> *shrug* ok.  Let a thousand "hey my xfs_check OOM'd" emails
> blossom! :)
> 
> FWIW, I did not have time to work on that prefetch bug yet today.  :(
> 

Why not replace it by a script that simply states that it's useless and
to run xfs_repair -n instead? It has been completely useless for the
best part of the past ten years... This way you don't remove it but
you'll sort of fix it :)

-- 
------------------------------------------------------------------------
Emmanuel Florac     |   Direction technique
                    |   Intellique
                    |	<eflorac@intellique.com>
                    |   +33 1 78 94 84 02
------------------------------------------------------------------------

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: Remove xfs_check for 3.2.0?

[Dave Chinner]

On Thu, May 08, 2014 at 11:04:10PM +0200, Emmanuel Florac wrote:
> Le Thu, 08 May 2014 15:40:57 -0500 vous écriviez:
> 
> > *shrug* ok.  Let a thousand "hey my xfs_check OOM'd" emails
> > blossom! :)
> > 
> > FWIW, I did not have time to work on that prefetch bug yet today.  :(
> > 
> 
> Why not replace it by a script that simply states that it's useless and
> to run xfs_repair -n instead? It has been completely useless for the
> best part of the past ten years... This way you don't remove it but
> you'll sort of fix it :)

xfs_check is already just a script that wraps xfs_db.

However, there's all the man page updates, all the external
documentation needs to be updated, etc. IOWs, it's not just a case
of a simply patching out the xfs_check script....

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs