From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (Postfix) with ESMTP id 20ECC7F3F for ; Fri, 9 May 2014 15:21:03 -0500 (CDT) Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by relay3.corp.sgi.com (Postfix) with ESMTP id AC47FAC001 for ; Fri, 9 May 2014 13:20:59 -0700 (PDT) Received: from mx0a-00082601.pphosted.com (mx0a-00082601.pphosted.com [67.231.145.42]) by cuda.sgi.com with ESMTP id FoQUjJglaHV0mfeQ for ; Fri, 09 May 2014 13:20:58 -0700 (PDT) Message-ID: <536D38A6.9030107@fb.com> Date: Fri, 9 May 2014 16:20:54 -0400 From: Josef Bacik MIME-Version: 1.0 Subject: Re: [PATCH] xfstests: filter out selinux xattrs for generic/062 References: <1399664668-719-1-git-send-email-jbacik@fb.com> <536D37F6.90603@redhat.com> In-Reply-To: <536D37F6.90603@redhat.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Eric Sandeen , linux-btrfs@vger.kernel.org, xfs@oss.sgi.com On 05/09/2014 04:17 PM, Eric Sandeen wrote: > On 5/9/14, 2:44 PM, Josef Bacik wrote: >> If you have selinux enabled getfattr will show the selinux xattrs, which screws >> with the golden output of generic/062. To make matters worse you can't just >> greap it out because we'll still get the preamble and newline from getfattr when >> the selinux attr is the only attr. So this is the voodoo I came up with after >> way more time than I'm comfortable admitting to make this test pass if you have >> selinux enabled. Thanks, > > I thought that we were pretty much universally mounting with an selinux > context, rather than allowing selinux to add its own on-disk attrs. > > Why is that not the case for this test? > > Works for me on this old kernel anyway: > > [root@bp-05 xfstests]# getenforce > Enforcing > [root@bp-05 xfstests]# ./check generic/062 > FSTYP -- xfs (non-debug) > PLATFORM -- Linux/x86_64 bp-05 2.6.32 > MKFS_OPTIONS -- -f -bsize=4096 /dev/sdc2 > MOUNT_OPTIONS -- -o context=system_u:object_r:nfs_t:s0 /dev/sdc2 /mnt/scratch > > generic/062 60s ... 3s > Ran: generic/062 > Passed all 1 tests > > Note the mount options above... > I have MOUNT_OPTIONS set to something else so I lose the context bit. Thanks, Josef _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs