From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (Postfix) with ESMTP id 90A967F3F for ; Tue, 13 May 2014 07:46:54 -0500 (CDT) Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by relay3.corp.sgi.com (Postfix) with ESMTP id 12E59AC009 for ; Tue, 13 May 2014 05:46:54 -0700 (PDT) Received: from userp1040.oracle.com (userp1040.oracle.com [156.151.31.81]) by cuda.sgi.com with ESMTP id HykHtXDFk0kQsjUz (version=TLSv1 cipher=AES256-SHA bits=256 verify=NO) for ; Tue, 13 May 2014 05:46:52 -0700 (PDT) Message-ID: <53721435.7090604@oracle.com> Date: Tue, 13 May 2014 20:46:45 +0800 From: Jeff Liu MIME-Version: 1.0 Subject: Re: [PATCH 2/9] xfs: fix incorrect error sign in xfs_file_aio_read References: <1399971373-6242-1-git-send-email-david@fromorbit.com> <1399971373-6242-3-git-send-email-david@fromorbit.com> In-Reply-To: <1399971373-6242-3-git-send-email-david@fromorbit.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Dave Chinner , xfs@oss.sgi.com On 05/13 2014 16:56 PM, Dave Chinner wrote: > From: Dave Chinner > > Signed-off-by: Dave Chinner > --- > fs/xfs/xfs_file.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c > index f499e47..37f98c6 100644 > --- a/fs/xfs/xfs_file.c > +++ b/fs/xfs/xfs_file.c > @@ -295,7 +295,7 @@ xfs_file_aio_read( > xfs_rw_ilock(ip, XFS_IOLOCK_EXCL); > > if (inode->i_mapping->nrpages) { > - ret = -filemap_write_and_wait_range( > + ret = filemap_write_and_wait_range( > VFS_I(ip)->i_mapping, > pos, -1); > if (ret) { > Reviewed-by: Jie Liu Cheers, -Jeff _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs