public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@sandeen.net>
To: Dave Chinner <david@fromorbit.com>, Adam Sampson <ats@offog.org>
Cc: xfs@oss.sgi.com
Subject: Re: [ANNOUNCE] xfsprogs: v3.2.0 released!
Date: Fri, 16 May 2014 20:01:11 -0500	[thread overview]
Message-ID: <5376B4D7.1000006@sandeen.net> (raw)
In-Reply-To: <20140517002309.GA18954@dastard>

On 5/16/14, 7:23 PM, Dave Chinner wrote:
> On Sat, May 17, 2014 at 12:02:15AM +0100, Adam Sampson wrote:
>> Dave Chinner <david@fromorbit.com> writes:
>>
>>> It is my pleasure to announce the release of v3.2.0 of the xfsprogs
>>> package.
>>
>> If this is built with DEBUG= (i.e. not defaulting to DEBUG=-NDEBUG),
>> several source files fail to compile -- it looks like there are a number
>> of assertions that haven't been updated for changes in the code:
> 
> Can't say I've ever built xfsprogs with "DEBUG=". I'm not sure
> there's really any benefit in doing so - it's preferable to have
> things like xfs_repair abort when it comes across an inconsistency
> it can't handle than to continue blindly along and making a bigger
> mess of the filesystem it's supposed to be fixing...
> 
> Anyway, we'll look to fix it for 3.2.1.

-NDEBUG is only default for libxfs/ AFAIK:

# grep -B1 NDEBUG libxfs/Makefile 
# don't try linking xfs_repair with a debug libxfs.
DEBUG = -DNDEBUG

For everything else, default should be -DDEBUG:

configure:    DEBUG=${DEBUG:-'-DDEBUG'}		    debug_build="$DEBUG"

so default is -DDEBUG for everything except libxfs, with -NDEBUG;
I'm not sure what '' does - break, apparently.  Seems like maybe just
a bit of a makefile mess and maybe old crufty code.
Patches accepted and all that.  :)

But maybe it's time to remove it as an option, and just DTRT everywhere.

>> (Errors from current Git, built with GCC 4.9. You also get a good crop
>> of warnings if you build it with clang 3.4.1's scan-build, which'd be
>> worth checking out in case there's anything serious there.)
> 
> ISTR that was done recently by Eric, and I've run clang recently,
> too.

Some, yeah.  I don't claim to have gotten it all cleaned up yet,
though.  We also keep track of what Coverity finds, chipping away
at a backlog of potential defects...

Thanks for the report, though, there's always more to do...

-Eric

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2014-05-17  1:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-16  5:56 [ANNOUNCE] xfsprogs: v3.2.0 released! Dave Chinner
2014-05-16 23:02 ` Adam Sampson
2014-05-17  0:23   ` Dave Chinner
2014-05-17  1:01     ` Eric Sandeen [this message]
2014-05-17 10:53     ` Adam Sampson
2014-05-19  2:55       ` Dave Chinner
2014-05-20  8:27         ` Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5376B4D7.1000006@sandeen.net \
    --to=sandeen@sandeen.net \
    --cc=ats@offog.org \
    --cc=david@fromorbit.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox