From: Eric Sandeen <sandeen@sandeen.net>
To: Dave Chinner <david@fromorbit.com>, xfs@oss.sgi.com
Subject: Re: [DISCUSS] Planning for new dev cycle (3.17)
Date: Tue, 10 Jun 2014 16:57:36 -0500 [thread overview]
Message-ID: <53977F50.3050607@sandeen.net> (raw)
In-Reply-To: <53971184.50008@sandeen.net>
On 6/10/14, 9:09 AM, Eric Sandeen wrote:
> On 6/10/14, 1:09 AM, Dave Chinner wrote:
>
>> There is a new version of this work (Eric's patches and the base
>> libxfs restructure) here:
>>
>> git://oss.sgi.com/xfs/xfs.git xfs-libxfs-restructure
>>
>> It's based on 3.15 with the current for-next branch merged into it
>> and then the changes done over the top, so it's about as up-to-date
>> as it can be. Comments welcome...
>
> Comment 1: doesn't build ;)
>
>
> make[1]: *** No rule to make target `fs/xfs/xfs_dir2_readdir.o', needed by `fs/xfs/xfs.o'. Stop.
> make[1]: *** Waiting for unfinished jobs....
> CC [M] fs/xfs/xfs_buf.o
> make: *** [_module_fs/xfs] Error 2
>
> problems w/ xfs_rtbitmap.o as well, patch follows.
>
> Comment 2: Coverity thinks this adds about 25 defects, I'll have to go
> look at why...
(whoops, I forgot to send this earlier)
I take that back, somehow it was still counting defects in the files that got moved.
At most it added one, but really this code is the same as upstream, so
it's probably just a coverity foible; the issue it finds seems real though,
I'll send a patch:
Error: FORWARD_NULL:
path:/mnt/test2/git/xfs/fs/xfs/libxfs/xfs_da_btree.c:2555:
cond_false: Condition "error", taking false branch
path:/mnt/test2/git/xfs/fs/xfs/libxfs/xfs_da_btree.c:2560:
if_end: End of if statement
path:/mnt/test2/git/xfs/fs/xfs/libxfs/xfs_da_btree.c:2564:
cond_false: Condition "bp", taking false branch
/mnt/test2/git/xfs/fs/xfs/libxfs/xfs_da_btree.c:2564:
var_compare_op: Comparing "bp" to null implies that "bp" might be null.
path:/mnt/test2/git/xfs/fs/xfs/libxfs/xfs_da_btree.c:2565:
cond_true: Condition "error", taking true branch
/mnt/test2/git/xfs/fs/xfs/libxfs/xfs_da_btree.c:2566:
var_deref_model: Passing null pointer "bp" to function "xfs_trans_brelse(xfs_trans_t *, xfs_buf_t *)", which dereferences it.
path:/mnt/test2/git/xfs/fs/xfs/xfs_trans_buf.c:443:2:
cond_true: Condition "tp == NULL", taking true branch
/mnt/test2/git/xfs/fs/xfs/xfs_trans_buf.c:444:3:
deref_parm: Directly dereferencing parameter "bp".
-Eric
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-06-10 21:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-09 22:33 [DISCUSS] Planning for new dev cycle (3.17) Dave Chinner
2014-06-10 6:09 ` Dave Chinner
2014-06-10 14:09 ` Eric Sandeen
2014-06-10 21:54 ` Dave Chinner
2014-06-10 21:57 ` Eric Sandeen [this message]
2014-06-10 11:58 ` Brian Foster
2014-06-10 21:48 ` Dave Chinner
2014-06-11 9:10 ` Dave Chinner
2014-06-12 20:01 ` Brian Foster
2014-06-12 23:28 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53977F50.3050607@sandeen.net \
--to=sandeen@sandeen.net \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox