* [PATCH] xfs/279: use MKFS_XFS_PROG, not hardcoded path
@ 2014-06-13 21:10 Eric Sandeen
2014-06-16 9:34 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Eric Sandeen @ 2014-06-13 21:10 UTC (permalink / raw)
To: xfs-oss, fstests
I'm really not sure why this wasn't this way from the start.
On some systems it's in /usr/sbin, and the test fails.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
diff --git a/tests/xfs/279 b/tests/xfs/279
index 872f8be..cde7d21 100755
--- a/tests/xfs/279
+++ b/tests/xfs/279
@@ -62,7 +62,7 @@ _check_mkfs()
{
echo "==================="
echo "mkfs with opts: $@" | sed -e "s,/dev/sd.,DEVICE,"
- /sbin/mkfs.xfs $@ 2>/dev/null > $tmp.mkfs.full
+ $MKFS_XFS_PROG $@ 2>/dev/null > $tmp.mkfs.full
if [ $? -ne 0 ]; then
echo "Failed."
return
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] xfs/279: use MKFS_XFS_PROG, not hardcoded path
2014-06-13 21:10 [PATCH] xfs/279: use MKFS_XFS_PROG, not hardcoded path Eric Sandeen
@ 2014-06-16 9:34 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2014-06-16 9:34 UTC (permalink / raw)
To: Eric Sandeen; +Cc: fstests, xfs-oss
On Fri, Jun 13, 2014 at 04:10:42PM -0500, Eric Sandeen wrote:
> I'm really not sure why this wasn't this way from the start.
> On some systems it's in /usr/sbin, and the test fails.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-06-16 9:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-13 21:10 [PATCH] xfs/279: use MKFS_XFS_PROG, not hardcoded path Eric Sandeen
2014-06-16 9:34 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox