[PATCH] Catch under/overflow cases in cvtnum() and cvttime().

Arkadiusz Miśkiewicz
2014-07-11T19:34:22Z

cvtnum() and cvttime() silently ignore overflows. This leads to error
conditions not being catched. Example:

$ xfs_quota -x -c 'limit -u bsoft=987654321098765432199 \
bhard=987654321098765432199 999' /
$

Fixed version:
$ xfs_quota -x -c 'limit -u bsoft=987654321098765432199 \
bhard=987654321098765432199 999' /
xfs_quota: Error: could not parse size 987654321098765432199.
xfs_quota: unrecognised argument bsoft=987654321098765432199

Signed-off-by: Arkadiusz Miśkiewicz <arekm@maven.pl>
---
libxcmd/input.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/libxcmd/input.c b/libxcmd/input.c
index c06b5b8..397a124 100644
--- a/libxcmd/input.c
+++ b/libxcmd/input.c
@@ -154,6 +154,8 @@ cvtnum(
int c;

i = strtoll(s, &sp, 0);
+ if ((i == LLONG_MIN || i == LLONG_MAX) && errno == ERANGE)
+ return -1LL;
if (i == 0 && sp == s)
return -1LL;
if (*sp == '\0')
@@ -238,6 +240,8 @@ cvttime(
char *sp;

i = strtoul(s, &sp, 0);
+ if (i == ULONG_MAX && errno == ERANGE)
+ return 0;
if (i == 0 && sp == s)
return 0;
if (*sp == '\0')
--
2.0.0