From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id 2136D7F47 for ; Sat, 12 Jul 2014 08:38:02 -0500 (CDT) Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by relay1.corp.sgi.com (Postfix) with ESMTP id E6B728F8054 for ; Sat, 12 Jul 2014 06:37:58 -0700 (PDT) Received: from sandeen.net (sandeen.net [63.231.237.45]) by cuda.sgi.com with ESMTP id FTUmpx87Hfoy3out for ; Sat, 12 Jul 2014 06:37:55 -0700 (PDT) Message-ID: <53C13A34.6020602@sandeen.net> Date: Sat, 12 Jul 2014 08:37:56 -0500 From: Eric Sandeen MIME-Version: 1.0 Subject: Re: [PATCH] Catch under/overflow cases in cvtnum() and cvttime(). References: <1405107244-14234-1-git-send-email-arekm@maven.pl> <53C06FF3.2090600@sandeen.net> <201407120813.27317.arekm@maven.pl> In-Reply-To: <201407120813.27317.arekm@maven.pl> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: =?UTF-8?B?QXJrYWRpdXN6IE1pxZtraWV3aWN6?= Cc: xfs@oss.sgi.com T24gNy8xMi8xNCwgMToxMyBBTSwgQXJrYWRpdXN6IE1pxZtraWV3aWN6IHdyb3RlOgo+IE9uIFNh dHVyZGF5IDEyIG9mIEp1bHkgMjAxNCwgRXJpYyBTYW5kZWVuIHdyb3RlOgo+PiBPbiA3LzExLzE0 LCAyOjM0IFBNLCBBcmthZGl1c3ogTWnFm2tpZXdpY3ogd3JvdGU6Cj4+PiBjdnRudW0oKSBhbmQg Y3Z0dGltZSgpIHNpbGVudGx5IGlnbm9yZSBvdmVyZmxvd3MuIFRoaXMgbGVhZHMgdG8gZXJyb3IK Pj4+IGNvbmRpdGlvbnMgbm90IGJlaW5nIGNhdGNoZWQuIEV4YW1wbGU6Cj4+Pgo+Pj4gJCB4ZnNf cXVvdGEgLXggLWMgJ2xpbWl0IC11IGJzb2Z0PTk4NzY1NDMyMTA5ODc2NTQzMjE5OSBcCj4+Pgo+ Pj4gICAgICAgICBiaGFyZD05ODc2NTQzMjEwOTg3NjU0MzIxOTkgOTk5JyAvCj4+Pgo+Pj4gJAo+ Pj4KPj4+IEZpeGVkIHZlcnNpb246Cj4+PiAkIHhmc19xdW90YSAteCAtYyAnbGltaXQgLXUgYnNv ZnQ9OTg3NjU0MzIxMDk4NzY1NDMyMTk5IFwKPj4+Cj4+PiAgICAgICAgIGJoYXJkPTk4NzY1NDMy MTA5ODc2NTQzMjE5OSA5OTknIC8KPj4+Cj4+PiB4ZnNfcXVvdGE6IEVycm9yOiBjb3VsZCBub3Qg cGFyc2Ugc2l6ZSA5ODc2NTQzMjEwOTg3NjU0MzIxOTkuCj4+PiB4ZnNfcXVvdGE6IHVucmVjb2du aXNlZCBhcmd1bWVudCBic29mdD05ODc2NTQzMjEwOTg3NjU0MzIxOTkKPj4KPj4gU28sIHN0cnRv bCgzKSBzdWdnZXN0cyBzZXR0aW5nIGVycm5vIHRvIDAgYmVmb3JlIHRoZSBjYWxsOgo+Pgo+PiBO T1RFUwo+PiAgICAgICAgU2luY2UgIHN0cnRvbCgpICBjYW4gIGxlZ2l0aW1hdGVseSAgcmV0dXJu ICAwLCAgTE9OR19NQVgsICBvciAKPj4gTE9OR19NSU4gKExMT05HX01BWCBvciBMTE9OR19NSU4g Zm9yIHN0cnRvbGwoKSkgb24gYm90aCBzdWNjZXNzIGFuZAo+PiBmYWlsdXJlLCB0aGUgY2FsbGlu ZyAgcHJvZ3JhbSBzaG91bGQgc2V0IGVycm5vIHRvIDAgYmVmb3JlIHRoZSBjYWxsLCBhbmQKPj4g dGhlbiBkZXRlci0gbWluZSBpZiBhbiBlcnJvciBvY2N1cnJlZCBieSBjaGVja2luZyAgd2hldGhl ciAgZXJybm8gIGhhcyAgYSAKPj4gbm9uLXplcm8gdmFsdWUgYWZ0ZXIgdGhlIGNhbGwuCj4+Cj4+ IERpdHRvIGZvciBzdHJ0b3VsKCkuCj4gCj4gSG0sIG15IG1hbiBwYWdlcyAzLjcwIGRvbid0IGhh dmUgc3VjaCBub3Rlcywgc3RydG9sKDMpOgo+IAo+IE5PVEVTCj4gICAgICAgIEluIGxvY2FsZXMg b3RoZXIgdGhhbiB0aGUgIkMiIGxvY2FsZSwgYWxzbyBvdGhlciBzdHJpbmdzIG1heSBiZSAKPiBh Y2NlcHRlZC4gIChGb3IgZXhhbXBsZSwgdGhlIHRob3VzYW5kcyBzZXBhcmF0b3Igb2YgdGhlIGN1 cnJlbnQgbG9jYWxlIG1heSBiZSAKPiBzdXBwb3J0ZWQuKQo+IAo+ICAgICAgICBCU0QgYWxzbyBo YXMKPiAKPiAgICAgICAgICAgIHF1YWRfdAo+ICAgICAgICAgICAgc3RydG9xKGNvbnN0IGNoYXIg Km5wdHIsIGNoYXIgKiplbmRwdHIsIGludCBiYXNlKTsKPiAKPiAgICAgICAgd2l0aCBjb21wbGV0 ZWx5IGFuYWxvZ291cyBkZWZpbml0aW9uLiAgRGVwZW5kaW5nIG9uIHRoZSB3b3Jkc2l6ZSBvZiB0 aGUgCj4gY3VycmVudCBhcmNoaXRlY3R1cmUsIHRoaXMgbWF5IGJlIGVxdWl2YWxlbnQgdG8gc3Ry dG9sbCgpIG9yIHRvIHN0cnRvbCgpLgo+IAo+Pgo+PiBJIGd1ZXNzIHRoYXQgaXMganVzdCB0byBl bnN1cmUgdGhhdCB0aGVyZSdzIG5vdCBhIGxlZnRvdmVyIGVycm5vCj4+IHdoZW4gd2UgbWFrZSB0 aGUgY2FsbD8gIFdvcnRoIGRvaW5nLCBtYXliZT8KPiAKPiBFUkFOR0UgaXMgY2hlY2tlZCBpbiBm ZXcgb3RoZXIgcGxhY2VzIGFscmVhZHkgaW4gaW5wdXQuYyBhbmQgbm9uZSBpbml0aWFsaXplIAo+ IGVycm5vIGJlZm9yZSBzdHJ0b3VsKCkgY2FsbC4KCmh0dHA6Ly9jLWZhcS5jb20vbWlzYy9lcnJu by5odG1sIHN1Z2dlc3RzIGl0IHRvbzoKCj4gSXQncyBvbmx5IG5lY2Vzc2FyeSB0byBkZXRlY3Qg ZXJyb3JzIHdpdGggZXJybm8gd2hlbiBhIGZ1bmN0aW9uIGRvZXMKPiBub3QgaGF2ZSBhIHVuaXF1 ZSwgdW5hbWJpZ3VvdXMsIG91dC1vZi1iYW5kIGVycm9yIHJldHVybiAoaS5lLgo+IGJlY2F1c2Ug YWxsIG9mIGl0cyBwb3NzaWJsZSByZXR1cm4gdmFsdWVzIGFyZSB2YWxpZDsgb25lIGV4YW1wbGUg aXMKPiBhdG9pKS4gSW4gdGhlc2UgY2FzZXMgKGFuZCBpbiB0aGVzZSBjYXNlcyBvbmx5OyBjaGVj ayB0aGUKPiBkb2N1bWVudGF0aW9uIHRvIGJlIHN1cmUgd2hldGhlciBhIGZ1bmN0aW9uIGFsbG93 cyB0aGlzKSwgeW91IGNhbgo+IGRldGVjdCBlcnJvcnMgYnkgc2V0dGluZyBlcnJubyB0byAwLCBj YWxsaW5nIHRoZSBmdW5jdGlvbiwgdGhlbgo+IHRlc3RpbmcgZXJybm8uCgpJIHdvbmRlciB3aHkg aXQgd2FzIHJlbW92ZWQgZnJvbSB0aGUgbWFuIHBhZ2UsIGl0IG1ha2VzIHNlbnNlIHRvIG1lLCBi dXQKbWF5YmUgSSdtIG1pc3Npbmcgc29tZXRoaW5nLgoKLUVyaWMKCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCnhmcyBtYWlsaW5nIGxpc3QKeGZzQG9zcy5z Z2kuY29tCmh0dHA6Ly9vc3Muc2dpLmNvbS9tYWlsbWFuL2xpc3RpbmZvL3hmcwo=