From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id 383A67F47 for ; Sat, 12 Jul 2014 08:43:13 -0500 (CDT) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay2.corp.sgi.com (Postfix) with ESMTP id DF025304039 for ; Sat, 12 Jul 2014 06:43:09 -0700 (PDT) Received: from sandeen.net (sandeen.net [63.231.237.45]) by cuda.sgi.com with ESMTP id Ti0hHK0zHWq1upBn for ; Sat, 12 Jul 2014 06:43:04 -0700 (PDT) Message-ID: <53C13B69.50702@sandeen.net> Date: Sat, 12 Jul 2014 08:43:05 -0500 From: Eric Sandeen MIME-Version: 1.0 Subject: Re: [PATCH] Catch under/overflow cases in cvtnum() and cvttime(). References: <1405107244-14234-1-git-send-email-arekm@maven.pl> <53C06FF3.2090600@sandeen.net> <201407120813.27317.arekm@maven.pl> <53C13A34.6020602@sandeen.net> In-Reply-To: <53C13A34.6020602@sandeen.net> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: =?UTF-8?B?QXJrYWRpdXN6IE1pxZtraWV3aWN6?= Cc: xfs@oss.sgi.com T24gNy8xMi8xNCwgODozNyBBTSwgRXJpYyBTYW5kZWVuIHdyb3RlOgo+IE9uIDcvMTIvMTQsIDE6 MTMgQU0sIEFya2FkaXVzeiBNacWba2lld2ljeiB3cm90ZToKPj4gT24gU2F0dXJkYXkgMTIgb2Yg SnVseSAyMDE0LCBFcmljIFNhbmRlZW4gd3JvdGU6Cj4+PiBPbiA3LzExLzE0LCAyOjM0IFBNLCBB cmthZGl1c3ogTWnFm2tpZXdpY3ogd3JvdGU6Cj4+Pj4gY3Z0bnVtKCkgYW5kIGN2dHRpbWUoKSBz aWxlbnRseSBpZ25vcmUgb3ZlcmZsb3dzLiBUaGlzIGxlYWRzIHRvIGVycm9yCj4+Pj4gY29uZGl0 aW9ucyBub3QgYmVpbmcgY2F0Y2hlZC4gRXhhbXBsZToKPj4+Pgo+Pj4+ICQgeGZzX3F1b3RhIC14 IC1jICdsaW1pdCAtdSBic29mdD05ODc2NTQzMjEwOTg3NjU0MzIxOTkgXAo+Pj4+Cj4+Pj4gICAg ICAgICBiaGFyZD05ODc2NTQzMjEwOTg3NjU0MzIxOTkgOTk5JyAvCj4+Pj4KPj4+PiAkCj4+Pj4K Pj4+PiBGaXhlZCB2ZXJzaW9uOgo+Pj4+ICQgeGZzX3F1b3RhIC14IC1jICdsaW1pdCAtdSBic29m dD05ODc2NTQzMjEwOTg3NjU0MzIxOTkgXAo+Pj4+Cj4+Pj4gICAgICAgICBiaGFyZD05ODc2NTQz MjEwOTg3NjU0MzIxOTkgOTk5JyAvCj4+Pj4KPj4+PiB4ZnNfcXVvdGE6IEVycm9yOiBjb3VsZCBu b3QgcGFyc2Ugc2l6ZSA5ODc2NTQzMjEwOTg3NjU0MzIxOTkuCj4+Pj4geGZzX3F1b3RhOiB1bnJl Y29nbmlzZWQgYXJndW1lbnQgYnNvZnQ9OTg3NjU0MzIxMDk4NzY1NDMyMTk5Cj4+Pgo+Pj4gU28s IHN0cnRvbCgzKSBzdWdnZXN0cyBzZXR0aW5nIGVycm5vIHRvIDAgYmVmb3JlIHRoZSBjYWxsOgo+ Pj4KPj4+IE5PVEVTCj4+PiAgICAgICAgU2luY2UgIHN0cnRvbCgpICBjYW4gIGxlZ2l0aW1hdGVs eSAgcmV0dXJuICAwLCAgTE9OR19NQVgsICBvciAKPj4+IExPTkdfTUlOIChMTE9OR19NQVggb3Ig TExPTkdfTUlOIGZvciBzdHJ0b2xsKCkpIG9uIGJvdGggc3VjY2VzcyBhbmQKPj4+IGZhaWx1cmUs IHRoZSBjYWxsaW5nICBwcm9ncmFtIHNob3VsZCBzZXQgZXJybm8gdG8gMCBiZWZvcmUgdGhlIGNh bGwsIGFuZAo+Pj4gdGhlbiBkZXRlci0gbWluZSBpZiBhbiBlcnJvciBvY2N1cnJlZCBieSBjaGVj a2luZyAgd2hldGhlciAgZXJybm8gIGhhcyAgYSAKPj4+IG5vbi16ZXJvIHZhbHVlIGFmdGVyIHRo ZSBjYWxsLgo+Pj4KPj4+IERpdHRvIGZvciBzdHJ0b3VsKCkuCj4+Cj4+IEhtLCBteSBtYW4gcGFn ZXMgMy43MCBkb24ndCBoYXZlIHN1Y2ggbm90ZXMsIHN0cnRvbCgzKToKPj4KPj4gTk9URVMKPj4g ICAgICAgIEluIGxvY2FsZXMgb3RoZXIgdGhhbiB0aGUgIkMiIGxvY2FsZSwgYWxzbyBvdGhlciBz dHJpbmdzIG1heSBiZSAKPj4gYWNjZXB0ZWQuICAoRm9yIGV4YW1wbGUsIHRoZSB0aG91c2FuZHMg c2VwYXJhdG9yIG9mIHRoZSBjdXJyZW50IGxvY2FsZSBtYXkgYmUgCj4+IHN1cHBvcnRlZC4pCj4+ Cj4+ICAgICAgICBCU0QgYWxzbyBoYXMKPj4KPj4gICAgICAgICAgICBxdWFkX3QKPj4gICAgICAg ICAgICBzdHJ0b3EoY29uc3QgY2hhciAqbnB0ciwgY2hhciAqKmVuZHB0ciwgaW50IGJhc2UpOwo+ Pgo+PiAgICAgICAgd2l0aCBjb21wbGV0ZWx5IGFuYWxvZ291cyBkZWZpbml0aW9uLiAgRGVwZW5k aW5nIG9uIHRoZSB3b3Jkc2l6ZSBvZiB0aGUgCj4+IGN1cnJlbnQgYXJjaGl0ZWN0dXJlLCB0aGlz IG1heSBiZSBlcXVpdmFsZW50IHRvIHN0cnRvbGwoKSBvciB0byBzdHJ0b2woKS4KPj4KPj4+Cj4+ PiBJIGd1ZXNzIHRoYXQgaXMganVzdCB0byBlbnN1cmUgdGhhdCB0aGVyZSdzIG5vdCBhIGxlZnRv dmVyIGVycm5vCj4+PiB3aGVuIHdlIG1ha2UgdGhlIGNhbGw/ICBXb3J0aCBkb2luZywgbWF5YmU/ Cj4+Cj4+IEVSQU5HRSBpcyBjaGVja2VkIGluIGZldyBvdGhlciBwbGFjZXMgYWxyZWFkeSBpbiBp bnB1dC5jIGFuZCBub25lIGluaXRpYWxpemUgCj4+IGVycm5vIGJlZm9yZSBzdHJ0b3VsKCkgY2Fs bC4KPiAKPiBodHRwOi8vYy1mYXEuY29tL21pc2MvZXJybm8uaHRtbCBzdWdnZXN0cyBpdCB0b286 Cj4gCj4+IEl0J3Mgb25seSBuZWNlc3NhcnkgdG8gZGV0ZWN0IGVycm9ycyB3aXRoIGVycm5vIHdo ZW4gYSBmdW5jdGlvbiBkb2VzCj4+IG5vdCBoYXZlIGEgdW5pcXVlLCB1bmFtYmlndW91cywgb3V0 LW9mLWJhbmQgZXJyb3IgcmV0dXJuIChpLmUuCj4+IGJlY2F1c2UgYWxsIG9mIGl0cyBwb3NzaWJs ZSByZXR1cm4gdmFsdWVzIGFyZSB2YWxpZDsgb25lIGV4YW1wbGUgaXMKPj4gYXRvaSkuIEluIHRo ZXNlIGNhc2VzIChhbmQgaW4gdGhlc2UgY2FzZXMgb25seTsgY2hlY2sgdGhlCj4+IGRvY3VtZW50 YXRpb24gdG8gYmUgc3VyZSB3aGV0aGVyIGEgZnVuY3Rpb24gYWxsb3dzIHRoaXMpLCB5b3UgY2Fu Cj4+IGRldGVjdCBlcnJvcnMgYnkgc2V0dGluZyBlcnJubyB0byAwLCBjYWxsaW5nIHRoZSBmdW5j dGlvbiwgdGhlbgo+PiB0ZXN0aW5nIGVycm5vLgo+IAo+IEkgd29uZGVyIHdoeSBpdCB3YXMgcmVt b3ZlZCBmcm9tIHRoZSBtYW4gcGFnZQoKQWN0dWFsbHkgaXQgc2VlbXMgdG8gc3RpbGwgYmUgdGhl cmU6Cmh0dHA6Ly9naXQua2VybmVsLm9yZy9jZ2l0L2RvY3MvbWFuLXBhZ2VzL21hbi1wYWdlcy5n aXQvdHJlZS9tYW4zL3N0cnRvbC4zI24xOTAKCmZpZGRseSBkZXRhaWwgYnV0IHByb2JhYmx5IHdv cnRoIGRvaW5nLi4uCgotRXJpYwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KeGZzIG1haWxpbmcgbGlzdAp4ZnNAb3NzLnNnaS5jb20KaHR0cDovL29zcy5z Z2kuY29tL21haWxtYW4vbGlzdGluZm8veGZzCg==