From: Eric Sandeen <sandeen@sandeen.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: Jeff Liu <jeff.liu@oracle.com>, "xfs@oss.sgi.com" <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfsprogs/quota: fix NULL pointer dereference in report_f
Date: Tue, 15 Jul 2014 07:54:06 -0500 [thread overview]
Message-ID: <53C5246E.9090202@sandeen.net> (raw)
In-Reply-To: <20140715101437.GB30363@infradead.org>
On 7/15/14, 5:14 AM, Christoph Hellwig wrote:
> On Fri, Jul 11, 2014 at 08:39:45PM -0500, Eric Sandeen wrote:
>>> Signed-off-by: Jie Liu <jeff.liu@oracle.com>
>>
>> Reviewed-by: Eric Sandeen <sandeen@redhat.com>
>>
>> I know hch had grand plans to make this all nicer, but based on Jeff's
>> followup emails, it looks like this is the only spot needed to simply
>> resolve the problems w/ nonexistent paths in quota, and is a small,
>> contained change we can easily make before the next point release.
>
> Didn't I say I'm fine with putting this in earlier even if I'd prefer
> a grand solution?
Yes, you did, but it never got a formal reviewed-by or got merged, so I bumped it :)
FWIW I did look at the grand solution, and there was .. something that
didn't make sense to me, so I backed off. Oh, yeah, I wasn't quite
sure what to do with:
add_args_command(init_args_command);
and
init_args_command();
in quota/init.c
-Eric
> either way, consider this:
>
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2014-07-15 12:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-14 9:49 [PATCH] xfsprogs/quota: fix NULL pointer dereference in report_f Jeff Liu
2013-11-14 14:09 ` Christoph Hellwig
2013-11-15 1:42 ` Jeff Liu
2013-11-15 14:09 ` Christoph Hellwig
2013-11-15 15:36 ` Jeff Liu
2013-11-16 2:54 ` Jeff Liu
2014-07-12 1:39 ` Eric Sandeen
2014-07-15 10:14 ` Christoph Hellwig
2014-07-15 12:54 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C5246E.9090202@sandeen.net \
--to=sandeen@sandeen.net \
--cc=hch@infradead.org \
--cc=jeff.liu@oracle.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox