From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <xfs-bounces@oss.sgi.com>
Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29])
	by oss.sgi.com (Postfix) with ESMTP id C69497F9E
	for <xfs@oss.sgi.com>; Wed, 16 Jul 2014 02:11:59 -0500 (CDT)
Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25])
	by relay2.corp.sgi.com (Postfix) with ESMTP id B110F304043
	for <xfs@oss.sgi.com>; Wed, 16 Jul 2014 00:11:56 -0700 (PDT)
Received: from aserp1040.oracle.com (aserp1040.oracle.com [141.146.126.69]) by
	cuda.sgi.com with ESMTP id skQCMGCt7Zru2kZu (version=TLSv1
	cipher=AES256-SHA bits=256 verify=NO) for <xfs@oss.sgi.com>;
	Wed, 16 Jul 2014 00:11:55 -0700 (PDT)
Message-ID: <53C62595.6010702@oracle.com>
Date: Wed, 16 Jul 2014 15:11:17 +0800
From: Jeff Liu <jeff.liu@oracle.com>
MIME-Version: 1.0
Subject: Re: [PATCH] xfs: fix uflags detection at xfs_fs_rm_xquota
References: <53C4F5DB.2060108@oracle.com>
	<20140715102520.GH30363@infradead.org>
In-Reply-To: <20140715102520.GH30363@infradead.org>
List-Id: XFS Filesystem from SGI <xfs.oss.sgi.com>
List-Unsubscribe: <http://oss.sgi.com/mailman/options/xfs>,
	<mailto:xfs-request@oss.sgi.com?subject=unsubscribe>
List-Archive: <http://oss.sgi.com/pipermail/xfs>
List-Post: <mailto:xfs@oss.sgi.com>
List-Help: <mailto:xfs-request@oss.sgi.com?subject=help>
List-Subscribe: <http://oss.sgi.com/mailman/listinfo/xfs>,
	<mailto:xfs-request@oss.sgi.com?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: xfs-bounces@oss.sgi.com
Sender: xfs-bounces@oss.sgi.com
To: Christoph Hellwig <hch@infradead.org>
Cc: "xfs@oss.sgi.com" <xfs@oss.sgi.com>


On 07/15/2014 18:25 PM, Christoph Hellwig wrote:
> On Tue, Jul 15, 2014 at 05:35:23PM +0800, Jeff Liu wrote:
>> From: Jie Liu <jeff.liu@oracle.com>
>>
>> We are intended to check up uflags against FS_PROJ_QUOTA rather than 
>> FS_USER_UQUOTA once more, it looks to me like a typo, but might cause
>> the project quota metadata space can not be removed.
> 
> This code was introduced by commit
> 9da93f9b7cdf8ab28da6b364cdc1fafc8670b4dc which attempts to fix the
> broken quotarm code.  Seems like we need a testcase for this
> functionality or just remove it.  Physically removing the quota file
> never seems that useful to me to start with..

Is there an approach to verify that a particular quota file inode has
been successfully removed?  It seems we have to do this in a test case
but am not yet figure out a way, or any thoughts for the test case?


Cheers,
-Jeff


_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs