From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (Postfix) with ESMTP id F11C67F3F for ; Wed, 16 Jul 2014 03:32:47 -0500 (CDT) Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by relay3.corp.sgi.com (Postfix) with ESMTP id 8A73DAC003 for ; Wed, 16 Jul 2014 01:32:44 -0700 (PDT) Received: from aserp1040.oracle.com (aserp1040.oracle.com [141.146.126.69]) by cuda.sgi.com with ESMTP id lQ7lc4nqD3ngJTJ5 (version=TLSv1 cipher=AES256-SHA bits=256 verify=NO) for ; Wed, 16 Jul 2014 01:32:43 -0700 (PDT) Message-ID: <53C6388C.8000608@oracle.com> Date: Wed, 16 Jul 2014 16:32:12 +0800 From: Jeff Liu MIME-Version: 1.0 Subject: Re: [PATCH] xfs: fix uflags detection at xfs_fs_rm_xquota References: <53C4F5DB.2060108@oracle.com> <20140715102520.GH30363@infradead.org> <53C62595.6010702@oracle.com> <20140716071250.GA1461@infradead.org> In-Reply-To: <20140716071250.GA1461@infradead.org> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Christoph Hellwig Cc: "xfs@oss.sgi.com" On 07/16/2014 15:12 PM, Christoph Hellwig wrote: > On Wed, Jul 16, 2014 at 03:11:17PM +0800, Jeff Liu wrote: >>> This code was introduced by commit >>> 9da93f9b7cdf8ab28da6b364cdc1fafc8670b4dc which attempts to fix the >>> broken quotarm code. Seems like we need a testcase for this >>> functionality or just remove it. Physically removing the quota file >>> never seems that useful to me to start with.. >> >> Is there an approach to verify that a particular quota file inode has >> been successfully removed? It seems we have to do this in a test case >> but am not yet figure out a way, or any thoughts for the test case? > > umount the filesystem and check that the field in the superblock > pointing to that kind of quota inode is zeroed out would be my > suggestion. Oh yes, after quota remove, the 'u' field of the quota inode will changed from u.bmx[0] = [startoff,startblock,blockcount,extentflag] 0:[0,16,1,0] to u = (empty) which can be used for the verification, thanks for your suggestion. :) Cheers, -Jeff _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs