[PATCH] xfs/007: add project quota Q_XQUOTRM test

[PATCH] xfs/007: add project quota Q_XQUOTRM test

[Jeff Liu]

From: Jie Liu <jeff.liu@oracle.com>

Add test for project quota Q_XQUOTRM operations, this patch also
update the golden output file to match the new output.

Signed-off-by: Jie Liu <jeff.liu@oracle.com>
---
 tests/xfs/007     | 15 ++++++++++-----
 tests/xfs/007.out |  4 +++-
 2 files changed, 13 insertions(+), 6 deletions(-)

diff --git a/tests/xfs/007 b/tests/xfs/007
index 8cc5bf3..ca05a3c 100755
--- a/tests/xfs/007
+++ b/tests/xfs/007
@@ -47,10 +47,12 @@ _supported_os Linux Irix
 
 _require_scratch
 _require_xfs_quota
+_require_xfs_mkfs_crc
+_require_xfs_crc
 
-_scratch_mkfs_xfs >/dev/null 2>&1
+_scratch_mkfs_xfs -m crc=1 >/dev/null 2>&1
 
-_qmount_option "uquota,gquota"
+_qmount_option "uquota,gquota,pquota"
 _qmount
 
 echo "*** umount"
@@ -58,21 +60,24 @@ umount $SCRATCH_MNT
 
 UQUOTINO=`xfs_db -c "sb 0" -c "p" $SCRATCH_DEV | grep uquotino | awk '{print $NF}'`
 GQUOTINO=`xfs_db -c "sb 0" -c "p" $SCRATCH_DEV | grep gquotino | awk '{print $NF}'` 
+PQUOTINO=`xfs_db -c "sb 0" -c "p" $SCRATCH_DEV | grep pquotino | awk '{print $NF}'`
 
 echo "*** Usage before quotarm ***"
 xfs_db -c "inode $UQUOTINO" -c "p core.nblocks" $SCRATCH_DEV
 xfs_db -c "inode $GQUOTINO" -c "p core.nblocks" $SCRATCH_DEV
+xfs_db -c "inode $PQUOTINO" -c "p core.nblocks" $SCRATCH_DEV
 
 _qmount
-echo "*** turn off user and group quotas"
-xfs_quota -x -c 'off -ug' $SCRATCH_MNT
-xfs_quota -x -c "remove -ug" $SCRATCH_MNT
+echo "*** turn off user/group/project quotas"
+xfs_quota -x -c 'off -ugp' $SCRATCH_MNT
+xfs_quota -x -c "remove -ugp" $SCRATCH_MNT
 echo "*** umount"
 umount $SCRATCH_MNT
 
 echo "*** Usage after quotarm ***"
 xfs_db -c "inode $UQUOTINO" -c "p core.nblocks" $SCRATCH_DEV
 xfs_db -c "inode $GQUOTINO" -c "p core.nblocks" $SCRATCH_DEV
+xfs_db -c "inode $PQUOTINO" -c "p core.nblocks" $SCRATCH_DEV
 
 # success, all done
 status=0
diff --git a/tests/xfs/007.out b/tests/xfs/007.out
index 0fc17ae..f370e5f 100644
--- a/tests/xfs/007.out
+++ b/tests/xfs/007.out
@@ -3,8 +3,10 @@ QA output created by 007
 *** Usage before quotarm ***
 core.nblocks = 1
 core.nblocks = 1
-*** turn off user and group quotas
+core.nblocks = 1
+*** turn off user/group/project quotas
 *** umount
 *** Usage after quotarm ***
 core.nblocks = 0
 core.nblocks = 0
+core.nblocks = 0
-- 
1.8.3.2

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfs/007: add project quota Q_XQUOTRM test

[Christoph Hellwig]

On Thu, Jul 17, 2014 at 10:30:58AM +0800, Jeff Liu wrote:
> From: Jie Liu <jeff.liu@oracle.com>
> 
> Add test for project quota Q_XQUOTRM operations, this patch also
> update the golden output file to match the new output.

Changing the test to require crc filesystems seems like a bad idea.

I'd suggest to simply do two passes instead: the first one unchanged,
and the second one testing project instead of group quotas.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfs/007: add project quota Q_XQUOTRM test

[Jeff Liu]

On 07/17/2014 17:07 PM, Christoph Hellwig wrote:
> On Thu, Jul 17, 2014 at 10:30:58AM +0800, Jeff Liu wrote:
>> From: Jie Liu <jeff.liu@oracle.com>
>>
>> Add test for project quota Q_XQUOTRM operations, this patch also
>> update the golden output file to match the new output.
> 
> Changing the test to require crc filesystems seems like a bad idea.
> 
> I'd suggest to simply do two passes instead: the first one unchanged,
> and the second one testing project instead of group quotas.

Sounds reasonable to me, will post an updated version soon.

Cheers,
-Jeff

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs