From: Jeff Liu <jeff.liu@oracle.com>
To: Dave Chinner <david@fromorbit.com>
Cc: "xfs@oss.sgi.com" <xfs@oss.sgi.com>
Subject: Re: [PATCH v3 00/10] xfs_ioc_bulkstat code refactoring and consolidation
Date: Thu, 31 Jul 2014 15:55:43 +0800 [thread overview]
Message-ID: <53D9F67F.9060609@oracle.com> (raw)
In-Reply-To: <20140729232748.GI26465@dastard>
Hi Dave,
On 07/30/2014 07:27 AM, Dave Chinner wrote:
> On Tue, Jun 03, 2014 at 05:17:42PM +0800, Jeff Liu wrote:
>> Hi folk,
>>
>> This is the revised patches for xfs_ioc_bulkstat consolidation and code
>> refactoring. As per Christoph's comments, I'm not include the per AG
>> inumber patch in this series given that I don't actually introduce the
>> relevant inumbers interface now. Similar to that reason, I also dropped
>> the per AG bulkstat patch, it would be included in parallel quota check
>> series.
>>
>>
>> v3->v2:
>> - one major bug fix is at xfs_bulkstat_ag_ichunk() regarding the user buffer
>> pointer operations, it should be defined as a pointer-to-pointer since it
>> would be updated inside xfs_bulkstat_ag_ichunk().
>>
>> - separate xfs_inumber consolidate patch into two patches, the first one
>> fix the formater function return value and consolidate the codes, another
>> one does the actual logic changes for better error handling.
>>
>> - Add a separate patch to get rid of the redundant user buffer count
>> checks at xfs_bulkstat()
>>
>> - fixed agino calculation issue at xfs_bulkstat_grab_ichunk().
>>
>> v2: http://oss.sgi.com/archives/xfs/2014-04/msg00554.html
>> v1: http://oss.sgi.com/archives/xfs/2013-12/msg00901.html
>>
>>
>> Any comments are welcome!
>
> Hi Jeff, I ported this to the current dev tree based on the
> xfs-libxfs-restructure branch, and I keep seeing fsstress failing
> with memory corruption after random bulkstat ioctls. I see regular
> failures with generic/013, generic/068, xfs/167 and the other
> fstress tests also randomly fail. The typical failure is glibc
> detected memory heap corruption on freeing the bulkstat structure
> after the ioctl:
>
> generic/068 42s ...*** Error in `./ltp/fsstress': double free or corruption (!prev): 0x00007f0224000b70 ***
> ======= Backtrace: =========
Sorry for my late response and thanks for help porting this patch series.
Now I can reproduce this issue frequently with generic/013, will try to fix
it ASAP.
Cheers,
-Jeff
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-07-31 7:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-03 9:17 [PATCH v3 00/10] xfs_ioc_bulkstat code refactoring and consolidation Jeff Liu
2014-07-29 23:27 ` Dave Chinner
2014-07-31 7:55 ` Jeff Liu [this message]
2014-08-01 6:09 ` Jeff Liu
2014-08-03 0:07 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D9F67F.9060609@oracle.com \
--to=jeff.liu@oracle.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox