From: Eric Sandeen <sandeen@sandeen.net>
To: Eric Sandeen <sandeen@redhat.com>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfs: deduplicate xlog_do_recovery_pass()
Date: Wed, 20 Aug 2014 23:36:40 -0500 [thread overview]
Message-ID: <53F57758.9070007@sandeen.net> (raw)
In-Reply-To: <53F5651C.8030206@redhat.com>
On 8/20/14, 10:18 PM, Eric Sandeen wrote:
> In xlog_do_recovery_pass(), there are 2 distinct cases:
> non-wrapped and wrapped log recovery.
>
> If we find a wrapped log, we recover around the end
> of the log, and then handle the rest of recovery
> exactly as in the non-wrapped case - using exactly the same
> (duplicated) code.
>
> Rather than having the same code in both cases, we can
> get the wrapped portion out of the way first if needed,
> and then recover the non-wrapped portion of the log.
>
> There should be no functional change here, just code
> reorganization & deduplication.
>
> The patch looks a bit bigger than it really is; the last
> hunk is whitespace changes (un-indenting).
>
> Tested with xfstests "check -g log" on a stock configuration.
which didn't actually hit any log wraps. Does xfstests
really not cover wrapped log recovery? anyway, something like this
on a small log:
[root@bp-05 xfstests]# while true; do mount /dev/sdc5 /mnt/scratch; ltp/fsstress -n 500 -d /mnt/scratch; src/godown -f /mnt/scratch; umount /mnt/scratch; done
hit plenty of log wraps w/ no problem.
-Eric
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-08-21 4:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-21 3:18 [PATCH] xfs: deduplicate xlog_do_recovery_pass() Eric Sandeen
2014-08-21 4:36 ` Eric Sandeen [this message]
2014-08-21 4:49 ` Dave Chinner
2014-08-21 4:58 ` Eric Sandeen
2014-08-21 5:12 ` Dave Chinner
2014-08-21 12:36 ` Brian Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F57758.9070007@sandeen.net \
--to=sandeen@sandeen.net \
--cc=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox