From: Eric Sandeen <sandeen@sandeen.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfsprogs: use abort() not ASSERT(0) for impossible switch case
Date: Thu, 21 Aug 2014 12:45:33 -0500 [thread overview]
Message-ID: <53F6303D.7060407@sandeen.net> (raw)
In-Reply-To: <20140821174414.GA28860@infradead.org>
On 8/21/14, 12:44 PM, Christoph Hellwig wrote:
> On Thu, Aug 21, 2014 at 12:32:02PM -0500, Eric Sandeen wrote:
>> The original reason for the expletive below has been lost
>> in the mists of time, but at any rate, ASSERT() goes away in
>> libxfs, and this leads static analysis checkers to believe that
>> XFS_BTNUM_MAX is possible, and that we might overflow an array
>> later when using it as an index.
>>
>> We can shut this up and mark it as truly impossible with abort().
>
> This won't work in kernel space, and we'd like to keep this file in sync.
Ah, right, sorry - spaced out that it was shared.
I'll add ASSERT_ALWAYS() to userspace then, perhaps.
Thanks,
-Eric
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-08-21 17:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-21 17:32 [PATCH] xfsprogs: use abort() not ASSERT(0) for impossible switch case Eric Sandeen
2014-08-21 17:44 ` Christoph Hellwig
2014-08-21 17:45 ` Eric Sandeen [this message]
2014-08-21 18:27 ` [PATCH V2] xfsprogs: use ASSERT_ALWAYS " Eric Sandeen
2014-08-21 22:55 ` Dave Chinner
2014-08-21 22:50 ` [PATCH] xfsprogs: use abort() not ASSERT(0) " Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F6303D.7060407@sandeen.net \
--to=sandeen@sandeen.net \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox