From: Eric Sandeen <sandeen@sandeen.net>
To: Eric Sandeen <sandeen@redhat.com>, xfs@oss.sgi.com
Subject: Re: [PATCH 5/5] xfs_repair: set proper ftype when moving to lost+found
Date: Sun, 07 Sep 2014 16:26:09 -0500 [thread overview]
Message-ID: <540CCD71.4020507@sandeen.net> (raw)
In-Reply-To: <1410108065-18156-6-git-send-email-sandeen@redhat.com>
On 9/7/14 11:41 AM, Eric Sandeen wrote:
> When we move files to lost+found, we're setting the
> filetype to UNKNOWN. This leaves an inconsistency which
> is discovered on a subsequent repair:
>
> would fix ftype mismatch (0/1) in directory/child inode 5838/5839
>
> Setting the proper ftype at the time of the move
> resolves this:
Ah, arekm points out that Jan already sent a patch to do this:
[PATCH] repair: Set ftype for entries in lost+found
http://oss.sgi.com/archives/xfs/2014-07/msg00314.html
Sorry, missed that.
-Eric
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-09-07 21:26 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-07 16:41 [PATCH 0/5] xfs_repair fixes, part 1 Eric Sandeen
2014-09-07 16:41 ` [PATCH 1/5] xfs_repair: clear bad flgs in process_dinode_int Eric Sandeen
2014-09-08 13:45 ` Brian Foster
2014-09-09 22:28 ` Christoph Hellwig
2014-09-09 22:33 ` Eric Sandeen
2014-09-09 23:48 ` Dave Chinner
2014-09-07 16:41 ` [PATCH 2/5] xfs_repair: preserve error state in process_shortform_attr Eric Sandeen
2014-09-08 13:45 ` Brian Foster
2014-09-09 22:29 ` Christoph Hellwig
2014-09-07 16:41 ` [PATCH 3/5] xfs_repair: fix dir refcount when '.' missing and dir is rebuilt Eric Sandeen
2014-09-08 13:45 ` Brian Foster
2014-09-08 14:25 ` Brian Foster
2014-09-08 14:44 ` Eric Sandeen
2014-09-08 14:33 ` Eric Sandeen
2014-09-07 16:41 ` [PATCH 4/5] xfs_repair: don't ASSERT on corrupt ftype Eric Sandeen
2014-09-08 0:10 ` Dave Chinner
2014-09-08 1:02 ` Eric Sandeen
2014-09-08 3:16 ` Dave Chinner
2014-09-08 3:18 ` Eric Sandeen
2014-09-08 6:23 ` Dave Chinner
2014-09-07 16:41 ` [PATCH 5/5] xfs_repair: set proper ftype when moving to lost+found Eric Sandeen
2014-09-07 21:26 ` Eric Sandeen [this message]
2014-09-07 17:02 ` [PATCH 6/5] xfs_repair: don't re-add root dotdot if root dir was rebuilt Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=540CCD71.4020507@sandeen.net \
--to=sandeen@sandeen.net \
--cc=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox